Broken logo image on checkout

Mike Straw
(@mikestraw)

2 years, 2 months ago

The logo image is broken on checkout:

This is happening because a space is inserted before the GET args, creating a URL like https://mysite.com/wp-content/plugins/bitpay-checkout-for-woocommerce/images/BitPay-Accepted-CardGroup.svg%20id=bitpay_logo

I was able to fix it in my local site by patching plugins/bitpay-checkout-for-woocommerce/build/BitPayLib/class-wcgatewaybitpay.php. I changed line 85 (inside get_icon_on_payment_page()) to:

return add_query_arg('id', 'bitpay_logo', $settings->get_payment_logo_url());

Hoping to see it fixed in a future version 🙂

Viewing 10 replies - 1 through 10 (of 10 total)

Thread Starter Mike Straw
(@mikestraw)

2 years, 2 months ago

The screenshot didn’t want to upload, but it’s visible here: https://share.cleanshot.com/rPKd6VBX

Bob Brodie
(@bobbrodie)

2 years, 2 months ago

Got it, thanks @mikestraw — we’ll look at getting this into 5.5.1.

Bob Brodie
(@bobbrodie)

2 years, 2 months ago

When you have a moment, could you share which version of the BitPay Checkout for WooCommerce plugin you’re using @mikestraw? Thanks!
Thread Starter Mike Straw
(@mikestraw)

2 years, 2 months ago
Sure @bobbrodie! I’m running Version: 5.5.0.

Currently I’m only running this in a development environment, so I’ll happily update to 5.5.1 as soon as it’s available.
- This reply was modified 2 years, 2 months ago by Mike Straw.
Bob Brodie
(@bobbrodie)

2 years, 2 months ago

Sounds great, thanks. We have that change coming in this PR, but I wanted to note that it affects line 312. We downloaded a fresh copy of the plugin from the marketplace just to check, but it’s odd that it would’ve been on line 85 for you unless the plugin was modified.

We should get this out the door tomorrow, so we’ll keep you posted. Thanks again!

Thread Starter Mike Straw
(@mikestraw)

2 years, 2 months ago

Awesome! I was updating the code in /build/ which is what runs locally. I’m assuming there’s a build process that puts those files out, but in the original source file, it’s on line 312, so it matches.

Bob Brodie
(@bobbrodie)

2 years, 2 months ago

Alright, yeah that sounds good. We have a GitHub Action that builds it, but I wasn’t sure if you were rebuilding from source. Thanks so much!

Thread Starter Mike Straw
(@mikestraw)

2 years, 1 month ago

@bobbrodie do you happen to know when the updated plugin will be released? I see the release was made on GitHub on July 2nd, but here it’s still showing 5.5.0.

Bob Brodie
(@bobbrodie)

2 years, 1 month ago

Hi @mikestraw we’re sorting out something with the deployment, hopeful to have it resolved on Mon.

Plugin Author BitPay
(@bitpay)

2 years, 1 month ago

Hello! Version 5.5.1 has been released with the change. Let us know if you continue to run into any issues and we’ll take a look. Thanks!