Support » Plugin: Advanced Custom Fields: Link » Broken in WordPress 4.8

  • Resolved JacobTheDev

    (@revxx14)


    I’m thinking some of the changes to the way links are handled broke this.

    Issues:

    – Can’t open the ‘edit link’ dialog
    – Duplicate ‘add link’ buttons
    – Duplicate link previews

    Screenshot:

    https://imgur.com/a/JOi0j

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Corey

    (@coreyw)

    Hi @revxx14,

    ACF Pro just added built-in support for the link field. That must be why you’re seeing duplicates.

    I haven’t had time yet to see how ACF implemented it, but it might require a simple data migration to get your existing links to work with the new link field. Or if you only have a few places, I would make sure they are both set to the same values and then disable and delete this plugin.

    Thread Starter JacobTheDev

    (@revxx14)

    Ah, that’s awesome! Took ’em long enough πŸ™‚

    Thanks for all your work maintaining this while ACF took their time!

    Plugin Author Corey

    (@coreyw)

    Glad you found it useful!

    And it looks like you shouldn’t lose any of your links and link titles when disabling this plugin. But the link target is handled differently, so it appears a migration will have to be done to preserve those.

    This plugin saved as either a 0 (self) or 1 (_blank). ACF saves as “” (self) or “_blank”. I will work on a migration script that should safely update those values across the database. Will post back here and update the readme when complete.

    Thank you.

    Plugin Author Corey

    (@coreyw)

    I have created a gist with a migration script that can be run that will update your database to preserve the “target” values of all fields.

    https://gist.github.com/coreyworrell/b3c04e56d665bc40fcf60f2d8e7eef4c

    Thread Starter JacobTheDev

    (@revxx14)

    Awesome, thanks πŸ™‚

    It might be worthwhile to update your plugin one last time to help users make the transition. I’d recommend adding a check to see if the native link field exists, and if so, stop processing your script and instead display a warning on the plugins page. It would help stop people from being confused as to why their fields suddenly stopped working.

    Plugin Author Corey

    (@coreyw)

    Thank you, I have released a new version which adds a notice and a page that runs the migration to the plugin now.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Broken in WordPress 4.8’ is closed to new replies.