Support » Plugin: WP-PostRatings » Broken images for Stars Crystal

  • Hello,

    It seems that the images are broken for Stars Crystal. I inspect the url, and see what I get:

    /wp-postratings/images/.stars_crystal/rating_on.gif

    and it should be:
    /wp-postratings/images/stars_crystal/rating_on.gif

    That point in the url breaks the image.

    Could you see it?
    Thanks!

Viewing 10 replies - 1 through 10 (of 10 total)
  • Plugin Author Lester Chan

    (@gamerz)

    Interesting, can u save the postratings options again in WP-Admin -> Ratings -> Ratings Options?

    Hello Lester, thanks for your response.

    Yes, I’ve saved several times, but still the same. And I’ve downloaded the latest version, and It’s still having this issue.

    Plugin Author Lester Chan

    (@gamerz)

    Weird, I can’t reproduce this issue on my end. The only thing that I can assume is the problem is the sanitize_file_name of https://github.com/lesterchan/wp-postratings/blob/master/postratings-options.php#L43. This is added to prevent XSS attacks in WP-Admin.

    But so far, you are the only one who reported this issue.

    I can report the same problem! After saving postratings option new, the stars do show up… BUT… now the function to show only the stars on frontpage is broken. as you can see here https://guenstig-kochen.at … after update every post has 0 stars

    further: after the update all customization made in the options of your plugin were gone!

    regards from austria
    Franz

    p.s.: that’s why my english is so bad 😉

    and also the problem “wp-postratings failed to verify referrer” is back

    Similar issue here that’s mostlikely also linked to sanitize_file_name. When trying to use stars(png) as name of the ratings folder it is saved as starspng. Of course this directory doesn’t exist, meaning the image alt text is displayed instead.

    • This reply was modified 1 year, 10 months ago by saenrl.
    Plugin Author Lester Chan

    (@gamerz)

    @saenrl but I have renamed existing stars(png) to stars_png https://github.com/lesterchan/wp-postratings/tree/master/images

    @gamerz well maybe YOU have but the blog I’m currently supporting hasn’t 😉

    Also people might add their own images with a special character in their name, so imho the better solution is to use a method that escapes special characters instead of removing them.

    Plugin Author Lester Chan

    (@gamerz)

    @saenrl huh? The sanitizer file name was release together with the rename images folder. Also sanitize_file_name is the correct way of doing things. The reason for doing that because of XSS exploits. So I will not use a homemade function to sanitize it as it will be reinventing the wheel and can potential cause XSS

    @gamerz Well, I can’t tell you how they managed that cause I’m just the poor guy now tasked with upgrading the blog (and learning wordpress along the way…).

    I’m just going to change the file and be done with it.

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘Broken images for Stars Crystal’ is closed to new replies.