Support » Plugin: Breeze - WordPress Cache Plugin » Broken caching in 1.1.7

  • Recently this code was introduced to the execute-cache.php:

    php
    if ( substr_count( $url_path, '?' ) > 0 ) {
        $filename = $url_path . '&guest';
    } else {
        $filename = $url_path . '?guest';
    }
    

    However, the corresponding code wasn’t updated inside the breeze_cache function, so generated cache files have incorrect path and are effectively useless.

    Which also begs the question, why is there even duplicated code to generate cache file path?

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author adeelkhan

    (@adeelkhan)

    Can you please elaborate on the use-case where the cache files were generated with incorrect paths?

    To give you a brief explanation of the snippet you quoted, the important part is the variable filename. The parameters of this variable are used to fix the paths and ensure compatibility with other plugins.

    Everywhere, just look at the damn code, like, say, line 214 in execute-cache.php which was not updated with the new logic, and appends guest without ? or & prefix. Alternatively, here’s the refactored code, so you won’t have to worry about updating copy-pasted code all over the place: https://pastebin.com/x9dEDKhc

    hitkodev

    (@hitkodev)

    Another fine bug (this time on multisite): $blog_id defaults to 1, and only resolves AFTER Breeze tries to serve cached content. Since Breeze prepends $blog_id to cache path, it tries to read from cache/breeze/1/..., but writes to cache/breeze/[resolved blog id]/..., which obviously doesn’t match.

    Plugin Author adeelkhan

    (@adeelkhan)

    Thanks to point out the issue. The issue will resolve in our upcoming build.

    jackthestripper

    (@jackthestripper)

    Why hasn’t this been addressed yet? Development of this plugin is extremely slow. It needs to be sped up if it’s to be considered a serious alternative to more established products. You’ve known about this serious bug for two months, and yet it’s still not fixed?

    Plugin Author adeelkhan

    (@adeelkhan)

    The issue fixed in 1.1.8

    The first issue seems to be fixed, but it still doesn’t properly cache multisite.

Viewing 7 replies - 1 through 7 (of 7 total)
  • You must be logged in to reply to this topic.