Hi,
Never heard this bug reported before… I wonder if it’s a conflict with your theme or another plugin and I would like to try to reproduce this.
Can you tell me which theme and which other plugins you are using?
Hi RavanH,
Thanks for the reply. It would be good if there was a fix.
I am using First-Mag as the theme and plugins (it’s quite a list):
- Advance Custom Themes
- Arconix Shortcodes
- Clean My Archives
- Contact Form 7
- Custom Sidebars
- Display Posts Shortcodes
- Easy Updates Manager
- Email Login
- Kirki Toolkit
- Obfuscate Email Address
- Relevanssi
- Shortcode Widget
- Simple Event Planner
- Subscribe2
- TinyMCE Advanced
- WordPress Slider Plugin
- Yoast SEO
I probably would normally have requested help, but I’m running to quite a tight deadline just now!
Relevanssi, that’s a search plugin right? Could you try disabling that one to see if the issue persists?
Sadly, without it, there are hardly any search results anyway. Just tried it again with both switch on and the FIRST search result is fine, any others are not.
Hmmm… the thing is that the search term needs to exist on the search result page. If not, there will indeed be a 404 response.
So it sounds like Relevanssi is causing search results that do not actually contain the searched terms.
This is a problem. I’ll have to try and find a way to get around it. When is your deadline?
The deadline’s Monday. And, although Relevanssi sometimes throws results that don’t contain the search term, without it A LOT of pages are missed altogether. And, the 404 issue happens with pages that DO contain the search term.
The site in question is http://sypotest8.co.uk. I’ll leave both Relevanssi and your plugin switched on for the next half hour for you to take a look.
I can suggest one very quick and dirty fix but this will diable the highlighting on any of the pages/posts that you click trough from the search result list.
Open the Highlight Search Terms plugin in your WordPress admin via Plugins > Editor (select the plugin from the dropdown on the top right) and find these three lines about half way down:
add_filter('post_link', array(__CLASS__,'append_search_query') );
add_filter('post_type_link', array(__CLASS__,'append_search_query') );
add_filter('page_link', array(__CLASS__,'append_search_query') );
then insert two forward slashes // at the start of each line like:
//add_filter('post_link', array(__CLASS__,'append_search_query') );
//add_filter('post_type_link', array(__CLASS__,'append_search_query') );
//add_filter('page_link', array(__CLASS__,'append_search_query') );
and save.
Indeed strange. Page that contain the search term still come up with a 404 on your site… I wonder if it is the Relevanssi plugin at all or something else.
In any case, try the “fix” above and I’ll work on finding a real fix and release it soon 🙂
Thanks for that. It fixed the 404 redirects nicely.
I’ve just released a fix in the development version https://downloads.wordpress.org/plugin/highlight-search-terms.zip which should work without breaking the search results click-through high lighting (meaning: search terms will also be highlighted on the page/post itself, not only on the search results page) … if you can try this version (download the zip, uninstall the current plugin and install the zip via the wordpress plugin uploader) and let me know if you stil get 404 pages, I’d be very grateful 🙂
Sorry, realised that could have come across a bit bluntly!
I mean, visit our site and try out a search(!)
Seems to be working now. Or did you find any remaining issues?
Hi RavanH,
The ONLY issue I had was with the 404 pages coming up. So, now you’ve fixed that, the lightweight plugin you’ve come up with is great!
Thanks very much for your swift work on this. It is very much appreciated.
Can I change my review?!?
Andrew Nevins
(@anevins)
WCLDN 2018 Contributor | Volunteer support
