Breadcrumb problem

  • Resolved ben909

    (@ben909)


    2 years, 11 months ago

    Hi

    Love the plugin. I’m just experiencing one small problem…

    I have categories showing on one page and am using HTML GET to display the links on another page. It’s working beautifully. I’ve enabled the breadcrumb trail above the links. The problem I have is that when you are looking at a list of links that belong to a child category, the final link in the breadcrumb trail is generated incorrectly.
    e.g

    The breadcrumb trail looks like this…
    Home – Category1 – Category2

    Clicking Home and Category1 works as expected. Clicking Category2 (which should just re-display the links we’re already looking at) shows the following message “All of your links must be assigned at least to one category to be displayed”.

    This is because the url path for Category2 is has too many levels… e.g domainname.com/category1/category2/
    when it should just be…
    domainname.com/category2/

    My question is, can the final link in the breadcrumb trail either be corrected or perhaps just changed into plain text, given that it only points to the links we’re already looking at anyway?

    *EDIT* to clarify, category 2 is a sub-category of category1. This is only a problem when dealing with sub-categories. The breadcrumb links work correctly when there is only one level of category.

    • This topic was modified 2 years, 11 months ago by ben909.
Viewing 15 replies - 1 through 15 (of 20 total)
1 2
  • Plugin Author Yannick Lefebvre

    (@jackdewey)

    2 years, 11 months ago

    Can you try commenting out line 36 in render-link-library-sc.php and seeing if it resolves your issue?

    Thread Starter ben909

    (@ben909)

    2 years, 11 months ago

    HI Yannick

    It solves it perfectly, thank you very much! The link now points to the correct place 🙂

    I wonder if that last link in the breadcrumb should just be text rather than a link, as that link will always point to the same url that is currently being viewed (I think).

    Anyway, thanks again!

    Plugin Author Yannick Lefebvre

    (@jackdewey)

    2 years, 11 months ago

    Could you test out an update before I make it public? I did change things around so that the last part of the breadcrumb is just text.

    You can get this test version from my github page: https://github.com/ylefebvre/link-library

    When downloading and extracting to your site, be careful not to end up with two different copies of the plugin on your server.

    Please consider donating to support this plugin’s development.

    Thread Starter ben909

    (@ben909)

    2 years, 11 months ago

    Awesome work. OK, I’ve given it a good test.

    It’s almost perfect, except for one scenario….

    From the home (category) page the user selects a sub-category, so the breadcrumb now looks like this…

    Home – Category1 – Subcat1

    Then the user clicks Category 1, but this link has been constructed incorrectly (missing a /).

    url should look like
    domain.com/home/category1
    but instead looks like
    domain.com/homecategory1

    Apart from that very minor bug, this is perfect!

    Plugin Author Yannick Lefebvre

    (@jackdewey)

    2 years, 11 months ago

    Just pushed out a new version. Can you see if this resolves the issue you mentioned?

    Thread Starter ben909

    (@ben909)

    2 years, 11 months ago

    You’ve nailed it. Great work Yannick, thanks!

    Plugin Author Yannick Lefebvre

    (@jackdewey)

    2 years, 11 months ago

    Thanks for the quick feedback. I will roll this change into the next official version of the plugin, which I should have out in the next week or two.

    Please consider donating to support this plugin’s development.

    Thread Starter ben909

    (@ben909)

    2 years, 11 months ago

    After further testing, it seems that the next/prev pagination links don’t work. I think this might be something to do with them still using page-id rather than permalinks perhaps? Clicking on prev/next removes the category filtering and just starts showing all links in the database.

    Plugin Author Yannick Lefebvre

    (@jackdewey)

    2 years, 11 months ago

    Sorry for the late response. So, the numbered page links work, but not the next/prev links, is that correct? Or none of them work? I can’t say that I’ve done a lot of testing around the combined used of permalinks and pagination. I’ll look at testing this over the next few days.

    Thread Starter ben909

    (@ben909)

    2 years, 11 months ago

    No need to apologise – there’s no rush, and no expectation of support!

    Yes, the page numbers work perfectly well. It’s just the prev/next links that don’t.

    I’m using HTML GET + Permalink, 6 links displayed per page. If there are any number of pages (>1) of links for a given category then you should see the problem. Page numbers work, but the prev/next links show every single link in the library, rather than those belonging to the category you were viewing.

    Plugin Author Yannick Lefebvre

    (@jackdewey)

    2 years, 11 months ago

    Please try updating to latest version (7.1.1) and see if it fixes the issue. I see why the Next would not work, but the code for the numbers and the previous link were the same so I did not make any changes there. Please see if the Next link now works.

    Thread Starter ben909

    (@ben909)

    2 years, 11 months ago

    I’ve updated, but I’m afraid it doesn’t work.

    e.g I have a category with 7 links. My pages show 6 links at a time. The page number links (1 & 2) work perfectly – 6 links on page one and the 7th link on page two.
    But if I’m on page 1 and I click next, it goes to
    https://<domain>/links/books/?linkresultpage=0&cat=books
    which shows a page with no links at all. I guess the page number shouldn’t be zero?
    Next and Prev both remain available to click, but they turn the page numbers negative…
    https://<domain>/links/books/?linkresultpage=-1&cat=books

    • This reply was modified 2 years, 11 months ago by ben909.
    Plugin Author Yannick Lefebvre

    (@jackdewey)

    2 years, 11 months ago

    Please try version 7.1.3 and see if it works correctly for you now.

    Thread Starter ben909

    (@ben909)

    2 years, 11 months ago

    That’s fixed it. Great work! Thank you 🙂

    Plugin Author Yannick Lefebvre

    (@jackdewey)

    2 years, 11 months ago

    Excellent! Thanks for your patience and the quick feedback.

Viewing 15 replies - 1 through 15 (of 20 total)
1 2
  • The topic ‘Breadcrumb problem’ is closed to new replies.