• Resolved Alex Diller

    (@thedelta)


    The first crumb of the breadcrumb path is always hardcoded as “Home”.
    Especially for multi language sites this is not optimal.

    Also the active crumb element is missing

    aria-current="page"

    (see https://getbootstrap.com/docs/5.2/components/breadcrumb/)

    How I fixed the issues atm:

    Modify helpers.php@127 (function areoi_generate_breadcrumbs)

    	if ( $post->post_parent ) {
    		$breadcrumbs = areoi_generate_breadcrumbs_parent( $breadcrumbs, $post->post_parent );
    
    		$title = __('Home');
    		$front_page_id = (int)get_option('page_on_front');
    		if ($front_page_id > 0) {
    			$title = get_the_title( $front_page_id );
    		}
    
    		$breadcrumbs[] = array(
    			'permalink' => home_url(),
    			'label'		=> $title,
    			'active'	=> false
    		);
    	}

    (If you only want to have Home translated, then remove the whole “$front_page_id” logic.)

    To fix the missing aria-current attribute, modify blocks/breadcrumb.php@21

    $list .= '<li class="breadcrumb-item active" aria-current="page">' . $breadcrumb['label'] . '</li>';

    @devs would be great to have this fixed / improved in the next version.
    Maybe add an option to the breadcrumb block (or global) to decide if the front_page title or the translated “Home” label should be used.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Miles

    (@areoimiles)

    Hi Alex,

    Thank you for flagging these issues.

    I have just released an update which looks to resolve them, using your suggested solution for the front page title and applying the correct aria-current value.

    I have added an additional attribute to the breadcrumb block so you can choose whether to replace Home with the Front Page Title.

    Hopefully, this resolves your problem but if you have any other issues please don’t hesitate to get back in touch.

    Thanks
    Miles

    P.S: if you like our plugin and are happy with the support we have provided, we would really appreciate it if you could take a few seconds to leave us a positive review.
    https://wordpress.org/support/plugin/all-bootstrap-blocks/reviews/#new-post

    Thread Starter Alex Diller

    (@thedelta)

    thanks for the fast update. ❤

Viewing 2 replies - 1 through 2 (of 2 total)
  • You must be logged in to reply to this topic.