Bracket in text lead to wrong report

  • Resolved Tim Codex

    (@tien-nguyen)


    8 years, 2 months ago

    Try this:

    $holy = '';
$test = array(
	'title' => __('Archive Page Designs', 'magone'),
	'icon' => 'dashicons-admin-page',
	'description' => __('Configure Archive Page Designs (Index, Category, Search, Author, ...', 'magone'),
	'settings' => $holy
);

    to get this message in report: RECOMMENDED: Possible variable $holy found in translation function in setup-customizer.php. Translation function calls must NOT contain PHP variables.

    Please double check your scanning algorithm.

    Thanks.

    https://wordpress.org/plugins/theme-check/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Samuel Wood (Otto)

    (@otto42)

    WordPress.org Admin

    8 years, 2 months ago

    This is a known issue, but not one that I’m planning to solve immediately. Having an unclosed set of parenths inside a translatable text statement is incorrect, since it’s a partial statement and statements to be translated should be whole.

    Thread Starter Tim Codex

    (@tien-nguyen)

    8 years, 2 months ago

    having an unclosed set of parenths inside a translatable text statement is incorrect

    Not agree, ex a case if the text is emoticon text :-(

    Language is unlimited, so we must not set any limit on any text.

    Plugin Author Samuel Wood (Otto)

    (@otto42)

    WordPress.org Admin

    8 years, 1 month ago

    Smilies should not be in translatable text, and while language is unlimited, means of translation are not. Text should be clear and whole to facilitate translation to other languages.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Bracket in text lead to wrong report’ is closed to new replies.