Bookmarklet and Elegant themes

  • fleckyoga

    (@fleckyoga)


    7 years, 7 months ago

    Hi, I was a regular user of the PressForward Nominate Bookmarklet until it stopped working earlier this year. I’m using Divi theme. Elegant themes say:-
    “I’ve looked into the issue with the bookmarklet. It doesn’t appear to be Divi’s fault. The way in which that plugin has implemented the bookmarklet’s server-side code is not in compliance with the Standards For Good Coding as defined by the makers of WordPress. Basically, the plugin manually bootstraps /wp-admin/admin.php but before it does that, it sets the WP_ADMIN constant to be false. That is what is causing the error. Some of Divi’s files that are expected to be available when admin.php is loaded, are not available due to WP_ADMIN being set to false by the plugin. I’m afraid this is not something that we can resolve as we have no control over the code of 3rd-party plugins. Sorry! :(”
    Any thoughts from Pressforward team? This was my favourite curation tool and it used to work beautifully.

Viewing 5 replies - 1 through 5 (of 5 total)
  • martingrandjean

    (@martingrandjean)

    7 years, 5 months ago

    Hi, same kind of problem on Divi. I drop a line here to be notified if somebody find a solution.

    olsonchnm

    (@olsonchnm)

    7 years, 4 months ago

    Hi, @fleckyoga,

    Is the bookmarklet still malfunctioning? Does it return an error?

    Thanks,

    E

    TTownsend

    (@ttownsend)

    7 years, 4 months ago

    Yes, this is still an issue. I’m using Extra, a Divi-based Elegant Themes product.

    I installed PressForward today and the Nominate This bookmarklet opens a blank popup (view sources shows it’s empty).

    Will this be fixed? I’ve got some content editors getting nasty with me (grin)

    Best,
    Trevor

    Plugin Author Aram Zucker-Scharff

    (@aramzs)

    7 years, 4 months ago

    Hi all,

    We’re in the process of rebuilding the bookmarklet, however, this technique is pulled directly from the old design of the PressThis bookmarklet. The WP_ADMIN variable is set that way directly because this is not a traditional admin page and shouldn’t activate the hooks that normally activate on admin pages, if the Divi theme is properly hooked this shouldn’t be an issue, but I understand that the Core team has moved away from this methodology.

    I have reviewed the relevant Core code and the main issue is that with the WP_ADMIN variable set to True, the Nominate This bookmarklet loads additional files and is therefore less performant and secure. If you are assured that the people with access to the Nominate This bookmarklet are trustworthy you can try editing the var define('WP_ADMIN', false); to true in includes\nomthis\nominate-this.php.

    Plugin Author Aram Zucker-Scharff

    (@aramzs)

    7 years, 4 months ago

    We do intend to resolve this issue with the rebuild of the Nominate This tool, but this might provide a more immediate solution.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Bookmarklet and Elegant themes’ is closed to new replies.