Bad user agent parsing | WordPress.org

Resolved krsch
(@krsch)

9 years, 6 months ago

The code in includes/functions/parse-user-agent.php:87 split user agent on a space or a semicolon and later on line 89 expects that there was at least one space or semicolon. It is not always so which breaks some rss feeds if the server is configured to display notices.
For example, W3C Feed Validator fails on a site that uses wp-statistics: the error.
It also breaks reading rss with a mobile app Antennapod which is how I discovered this bug.

https://wordpress.org/plugins/wp-statistics/

Viewing 6 replies - 1 through 6 (of 6 total)

Plugin Contributor Greg Ross
(@gregross)

9 years, 6 months ago

Can you provide an example user agent?

Thread Starter krsch
(@krsch)

9 years, 6 months ago

I think it should be “FeedValidator/1.3”

Plugin Contributor Greg Ross
(@gregross)

9 years, 6 months ago

I’ll take a look, there’s a new version of the parsing code that will be included in the next release and it doesn’t look to have the same issue.

Plugin Contributor Greg Ross
(@gregross)

9 years, 6 months ago

I’ve committed a fix for the next release.

Thread Starter krsch
(@krsch)

9 years, 6 months ago

It looks like this issue will be gone in the next release. Unfortunately I cannot test it, so when the next version is released I will ask the site owner to update and see if the bug is gone.

Plugin Contributor Greg Ross
(@gregross)

9 years, 6 months ago

If you want to test out the new code you can download the updated file here:

http://plugins.svn.wordpress.org/wp-statistics/trunk/includes/functions/parse-user-agent.php

and manually update your install.

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘Bad user agent parsing’ is closed to new replies.

Tags

In: Plugins
6 replies
2 participants
Last reply from: Greg Ross
Last activity: 9 years, 6 months ago
Status: resolved