Support » Plugin: WP-SpamShield » autoptimize compatibily; too broad an exclusion?

  • Hi there;
    I’m Autoptimize’s developer. A user of both our plugins notified me of the fact that WP-Spamshield changes the JS-optimization exclusion list, adding .php, jquery. Excluding .php is not needed, as AO only aggregates .js files, but that is less important.

    Excluding jquery however, seems like a too-big a fishing net really, as that means you’re not only excluding jquery(.min).js, but any JS injected by any plugin that has jquery in the name. This, as far as I can tell, is not needed for WP-spamshield to function but (and there we have the problem) as a result it leaves a lot of JS unoptimized. A better exclusion-string would probably just be jquery.js or if you want to cover all variations jquery.js, jquery-min.js, jquery.min.js. Can you look into this for a future release?

    Do let me know if I can be of any assistance here (or via futtta-at-gmail-dot-com).

    thanks!
    frank

    https://wordpress.org/plugins/wp-spamshield/

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Contributor Red Sand Media Group

    (@redsand)

    Hi Frank,

    Thanks for getting in touch.

    Yes, it was necessary to add that to ensure compatibility. Jquery absolutely is necessary for WP-SpamShield, so that’s why we added the exclusion. 🙂

    Feel free to get in touch with us through the WP-SpamShield Support form on our site so we can email back and forth. I’ll be happy to collaborate on alternate compatibility solutions. I have a few suggestions for Autoptimize to improve its compatibility as well.

    – Scott

    @redsand

    I’ll be happy to collaborate on alternate compatibility solutions. I have a few suggestions for Autoptimize to improve its compatibility as well.

    I don’t know how or how long it will take you to come up with a better solution, but please. Till then DO change the code provided at Known Issues and Plugin Conflicts
    I was going crazy trying to figure out and debug the fact that I was typing “,wp-spamshield,jquery” and getting “,jquery,.php

    Not only that but now we canNOT get rid of it. No matter what we do “,jquery,.php” keeps coming back excluding (as Frank @futtta mentioned) ALL our jquery strings.
    I have not found out whether it is Autoptimize or SpamShield responsible for this behaviour but it is definitely bad 🙁
    I would hate deactivating SpamShield but I guess we will have to.

    Other than that, thank you both for your excellent work.
    marikamitsos

    PS: This string is two weeks old. Please let us know if there was any progress.
    We are now on wordpress 4.4, Autoptimize v2.0.0 and SpamShield v1.9.6.8

    @redsand; still eagerly awaiting feedback 🙂

    Plugin Contributor Red Sand Media Group

    (@redsand)

    @marikamitsos: Hey there. If you’re having issues please start a separate thread or contact us directly through the WP-SpamShield Support page. (The latter is the best option.) If you notice that’s in the section “Plugins that previously had compatibility issues, but are now compatible.” There’s no need to add any code, and we went and removed that altogether. The plugin takes care of the since version 1.8.9.9. If you still have further issues, feel free to use Compatibility Mode.

    @frank: Hey Frank! Had a lot on our plate the last few weeks, but I’ll getting back to you soon! 🙂

    @redsand: Hello and thank you for the reply.

    …please start a separate thread or… …feel free to use Compatibility Mode.

    I am aware of the forum rules. Also, I had already checked the Compatibility Mode which we are not able to use since we do use JetPack with comments module enabled. So, using the the WP-SpamShield Support page would not help at all. Anyway.

    Hey Frank! Had a lot on our plate the last few weeks, but I’ll getting back to you soon

    Thanks again for looking into it.

    Plugin Contributor Red Sand Media Group

    (@redsand)

    @marikamitsos:

    You’re very welcome. 🙂

    Yes, the forum rules are just there to help keep things running smoothly…I don’t point that out to be a pain, but rather the fact that it makes it easier for us to help you. The forums automatically alert us to new support threads, so it makes it quicker for plugin authors to respond, as opposed to adding on to someone else’s thread, which we are not always alerted to.

    Anyway, if we can help, please feel free to get in touch, and we will be happy to help. 🙂

    – Scott

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘autoptimize compatibily; too broad an exclusion?’ is closed to new replies.