Hi,
The new version 4.6.2 only concerned the admin part of the plugin, so the way it works haven’t changed at all.
It does sound normal, though, right? If both files are named “Mentoring Success” they would both want to be “after-mentoring-success.jpg”. However, since the filename exists already, it wouldn’t let you rename it.
So yes, clicking on the buttons would do nothing in this case.
However, the odd part is that the button is shown for the first one; the filename is already fine so it shouldn’t be displayed.
Can you confirm what is the exact issue?
I’m still not clear about the recent change. Both the settings and bulk renaming page looks exactly the same when comparing 4.6.2 with 4.5.9.
Both files are TITLED “Mentoring Success”, but one of them has a matching filename and should not be listed for renaming. There should only be one entry. Looks like you agree.
Having said that, for the file that needs renaming, it’s a good idea to mention the conflict, hide the button, and just display the Edit link. No point showing a button that does nothing.
I’m not sure what you need me to confirm. This should be easy to replicate. Just upload the 2 files, disable renaming, match the titles, re-enable renaming and voila.
Changes concern the update process and a little tool to test the speed of the install, it’s helpful for debugging. Nothing concerning the renaming itself.
I have tried to replicate it but couldn’t. Also, this would be a very obvious bug and thousands of users would have experienced it right away. Something else is going on, I think it might be related to your install and the encoding of those files.
That said, if you think you can replicate it on any install, I could share one with you, you would replicate the bug. If you can do that, I will definitely find the issue and fix it 🙂
Using a Vanilla site, with no media-handling plugins and a default theme, this is what happens:
- Uploaded the same file as “mentoring-success.jpg”, “mentoring-success-2.jpg” and “men-mentoring-success.jpg”, while ensuring consistent encoding
- Changed all the titles to “Mentoring Success”
- Installed and activated Media File Renamer
In the media library, “mentoring-success-2.jpg” had no renaming buttons. That’s already incorrect.
The other 2 had renaming buttons with the suggested file name “mentoring-success.jpg”, which means that the plugin wanted to rename the correctly named file. That’s also incorrect.
See https://1drv.ms/u/s!AvYtwWI4b_-wsz_6x7q9kBW9iHob?e=cblD98
In the bulk renamer, there were 2 entries for those same images. They both had the correct title, current filename of “men-mentoring-success.jpg” and desired filename of “mentoring-success.jpg”. In fact, the current filename of one of them was incorrect.
See https://1drv.ms/u/s!AvYtwWI4b_-ws0BsaWOqsIbRFmsm
My guess is that the plugin works OK when there are no conflicts, so it will take people time to notice. I just happened to be testing the plugin for our other ticket and paid close attention.
Yes, this is exactly what I did, but that’s not happening for me. And for most users too, I supposed, since I haven’t heard about it.
Is it happening with all your installs?
Is your server running Windows Server? I guess that’s my big question, in fact. Almost no hosting services are running Windows these days for PHP so that could be why I can’t replicate your issue and why nobody else says anything.
No, my web server is LiteSpeed on CloudLinux and PHP 7.3.
I’ll email you login details, so you can check.
