Support » Plugin: footnotes » Auto load post compatibility [UPDATE]

Viewing 15 replies - 1 through 15 (of 21 total)
  • Plugin Author pewgeuges

    (@pewgeuges)

    Hello,

    This has now been implemented and will get into the upcoming v2.0.6. Just to be sure, what did you replace exactly and is this the intended output on post #32:

    
    <‌div id="footnote_references_container_32" style="">
    

    The other part of your request is related to v2.0.5 breaking autoload. The single biggest change in v2.0.5 is the change in priority, that fixed sites brokeo since a long time by the reference container showing up at the wrong place, on some sites with a label hidden by other features, because it came to late.

    If that fix breaks other sites, priority must become customizable.

    Best regards.

    Plugin Contributor Jimmy Thai

    (@docteurfitness)

    Hello,

    Thank you for replying to my request.

    To make the plugin compatible with the auto load post function, I had added code in these 5 files :

    /wp-content/plugins/footnotes/class/task.php

    the 4 files in /wp-content/plugins/footnotes/templates/public

    You can see modif by comparaison here : https://gofile.io/d/xymFGB

    Plugin Author pewgeuges

    (@pewgeuges)

    Hi @docteurfitness,

    Thank you a lot for sharing the working code and helping footnotes fix the autoload bug!

    Previously I only replaced a random prefix with the post ID for v2.0.3. Now we’ll need to fix the duplicate post # as in:

    
    <‌sup id="footnote_plugin_tooltip_14476_1_14476" class="footnote_plugin_tooltip_text" onclick="footnote_moveToAnchor_14476('footnote_plugin_reference_14476_1_14476');">(1)</‌sup>
    

    Do you agree that the output in upcoming v2.0.5 (not v2.0.6) will be e.g. id="footnote_plugin_tooltip_14476_1"? Trying to fix what I did before.

    Another concern coming in here is UX. A number of settings are hard-coded right in these template files:

    • Having the scroll target at half window height seems unexpected and impractical, so I set it to 12% from top. Do you prefer half-height? Sure that ought to have its setting in the dashboard.
    • Scroll speed: I found the original one second duration tedious, so I decreased it to 80 ms. How do you think? (Another wanted dashboard item.)
    • The tooltip display has a predelay, a fade-in speed, a fade-out speed. The predelay is originally 400 ms and so it is on docteur-fitness.com. After doubling it to leave time clicking, I think now it should be 0 when the box does not cover the footnote referrer. I’ve also set fade-in from unset to 200, and fade-out from 100 to 2000, assuming the infobox doesn’t cover text to read.

    It seems the new behavior was well received, and if you agree it will be kept or improved, and become default once the missing dashboard sections can be implemented.

    Many thanks again.

    Best regards,
    @pewgeuges

    • This reply was modified 3 months, 3 weeks ago by pewgeuges.
    • This reply was modified 3 months, 3 weeks ago by pewgeuges.
    • This reply was modified 3 months, 3 weeks ago by pewgeuges.
    Plugin Contributor Jimmy Thai

    (@docteurfitness)

    Hello,

    thank you for your reply.

    I find the half-height setting good but it is personal.
    For the speed, I also think it’s good like that 🙂

    I’m glad you like this improvement, it’s really a big improvement compared to other footnotes plugins 😀

    Plugin Author pewgeuges

    (@pewgeuges)

    Hello,

    Thank you a lot for your feedback. I’m implementing your bugfix to be available in upcoming v2.0.5beta0 given the v2.0.5 release caused you trouble and was rolled back.

    I apologize for altering priority levels, fixing things on many sites like my sandbox using Twenty Twenty, but in other WordPress instances disturbing public pages and even the block editor, where this plugin is not even supposed to be called, messing with user data. All our future releases (until the blog engine has added support for all priority levels) will be free from the problem that supposedly broke your implementation of infinite scroll support on docteur‑fitness.com.

    Speeds have been set back to almost legacy since these were preferred. Indeed half height is not unpleasant, and slow animation is OK for not too many notes.

    Just a question about the tooltips. Although you are using current stable v2.0.4, they don’t work and I suspect it’s only a missing instance of _[‌[post_id]‌]. In your footnote.html shouldn’t there be this:

    
    id="footnote_plugin_tooltip_text_[‌[id]‌]_[‌[post_id]‌]"
    

    for the tooltip to be called by the script in your tooltip.html that has it right:

    
    tip: "#footnote_plugin_tooltip_text_[‌[id]‌]_[‌[post_id]‌]",
    

    As a side note: In the reference container, the new template released with v2.0.0 aims to improve UX by making the entire left zone clickable in front of the note text, not only the number (with or without an arrow), or the arrow, alone.

    Thanks to your code, when support for autoload has been implemented natively, you are welcome to try out the new layout with prepended arrows or do you like the arrows the legacy way in an extra column, and the numbers not clickable?

    Best regards,

    @pewgeuges

    Plugin Contributor Jimmy Thai

    (@docteurfitness)

    thank you for your message 🙂

    I must confess that I don’t use tooltips and that I didn’t check if it worked well with version 2.0.4.

    I think I prefer the new layout with prepended arrows 🙂

    Best regards,

    (sorry for my english)

    Plugin Author pewgeuges

    (@pewgeuges)

    Hello @docteurfitness,

    Thanks a lot for your feedback, no worries, and we’re glad that the new layout is preferred. We’ve just made available a release candidate for the on-coming v2.0.5. Everything is implemented for autoload / infinite scroll, and there are zero critical changes:

    = 2.0.5rc0 =
    – Update: Autoload / infinite scroll support added thanks to @docteurfitness https://wordpress.org/support/topic/auto-load-post-compatibility-update/‌
    – Bugfix: Settings style sheet unenqueued to fix input boxes on public pages (enqueued for 2.0.4)
    – Bugfix: Public style sheet: Footnote referrers: deleted vertical align tweaks for cross-theme and user agent compatibility
    – Bugfix: Public style sheet: Reference container: auto-extending column to fit widest, to fix display with short note texts
    – Bugfix: Public style sheet: Reference container: IDs: slightly increased left padding
    – Bugfix: Public style sheet: Reference container: unset width of text column to fix site issues
    – Update: Enable all hooks by default to prevent footnotes from seeming broken in post titles
    – Bugfix: Restore cursor shape pointer over ‘Continue reading’ button after hyperlink removal
    – Update: Tooltip infobox: set display predelay to 0 for responsiveness (was 800 since 2.0.0, 400 before)
    – Bugfix: Reference container: collapse button fully clickable, not sign only
    – Bugfix: Reference container: collapse button ‘collapse’ with minus sign not hyphen-minus
    – Bugfix: Translations: Spelling error in en_GB and en_US

    It’s the developer version currently (November 5, 2020) available at the bottom of https://wordpress.org/plugins/footnotes/advanced/

    We’d be interested in learning how it works out and whether the bug you reported will now be fully fixed.

    Thanks again.

    Best regards,
    @pewgeuges

    • This reply was modified 3 months, 3 weeks ago by pewgeuges.
    • This reply was modified 3 months, 3 weeks ago by pewgeuges.
    Plugin Contributor Jimmy Thai

    (@docteurfitness)

    Hello,

    thank you for everything

    I installed the production version and there seems to be a problem with the first article.

    For the other loaded articles, it works fine though.

    To illustrate this I made a video with before/after installation.

    https://streamable.com/y78xml

    Best regards

    Plugin Author pewgeuges

    (@pewgeuges)

    Hello,

    Thank you very much for this screen video from your test environment. AFTER shows several disorders:

    1. As you report, the links dont work on page 1. I don’t know where that comes from, can only confirm they work fine in the tests I’ve run.
    2. The footnote referrers are sitting too low. That occurred when I switched from Twenty Twenty to a theme for testing, and was solved by deleting three longstanding vertical align rules that even disturbed display in some browsers other than Chrome. Currently this fix (“Bugfix: Layout: Footnote referrers: deleted vertical align tweaks for cross-theme and user agent compatibility”) is available in our release candidate v2.0.5rc1. RC2 is ready for commit and will be uploaded after. This version is available at the bottom of https://wordpress.org/plugins/footnotes/advanced/
    3. The arrows are stacked, not prepended. That is a line breaking issue. There seems to be no working CSS rule keeping digits, symbols and punctuation together while allowing breaks after spaces. In v2.0.5rc2 the no-break and the break opportunities will be hard-coded using CSS and bracketing elements.

    I’ll upload v2.0.5rc2 after responding in another thread. If you would like to try it out in your test environment, I’d be thankful for any further feedback.

    Best regards,
    @pewgeuges

    Plugin Contributor Jimmy Thai

    (@docteurfitness)

    After installing the latest version in production, I don’t seem to have seen any change.
    Was it uploaded to WordPress?

    https://streamable.com/pmsqz0

    Thanks Mark. I went to the Advanced page, but the two latest versions are 2.03 and 2.04, which I reverted to last night.

    Ack! 2.06 is a disaster. I have to roll back. Footnotes are appearing on the main page where the summarized version of writings appear, and then they disappear when you open the article!

    Plugin Author pewgeuges

    (@pewgeuges)

    @docteurfitness,

    Only this evening was I able to release the next bugfix v2.0.6. This is now available. V2.0.5 was rolled back due to the priority level flaw implemented in good faith as a proven fix, but backfiring instantly when used elsewhere. Please skip v2.0.5 and switch to v2.0.6.

    Thank you for the new video. It shows indeed the same problem on the first page. Does the code work only when loaded by Ajax? Did you install the plugin as-is or modified? I’ll try to get a v2.0.7rc0 ready next.

    @mmallett,

    That is correct, as v2.0.5 was rolled back, and I didn’t have v2.0.6 release-ready. Now current is v2.0.6. Hopefully it will fix what was wrong with 2.0.5, and I know as stated in the changelog that it contains a number of indispensable fixes for layout.

    Best regards,
    @pewgeuges

    Plugin Contributor Jimmy Thai

    (@docteurfitness)

    @pewgeuges

    unfortunately, the new version does not work on my website.

    the footnotes n°1 is annotated “15” as on the video. https://streamable.com/pmsqz0

    The footnote block at the bottom is not visible.

    However, it works on the second post with 2.0.6 but not with developpment version (nothing works)

    Plugin Author pewgeuges

    (@pewgeuges)

    @mmallett, I didn’t make that much edits. What we did is mainly to get the output strings right. Beside the priority level changes, that have been rolled back ASAP, I don’t see the cause of the disorder.

    @docteurfitness, Thanks for the video. Do you have an online test suite where I can get the page sources to try to better understand? Again, I didn’t change the algorithm for these releases. It was all about changing the output to get it more suitable to our needs, as you suggested.

    As of 2.0.6 it is very close to 2.0.5rc1. I’ll diff them to better understand what’s going wrong.

    Best regards.

Viewing 15 replies - 1 through 15 (of 21 total)
  • You must be logged in to reply to this topic.