Support » Plugin: Shariff Wrapper » At least the facebook-button is missing a rel=”noopener”

  • Resolved Thomas A. Reinert

    (@thomas-a-reinert)


    Hi there and thanks for this plugin.
    I´m not using too many of the social media buttons but at least the facebook-button is missing a “noopener” in rel=”noopener nofollow” while the other buttons I use have it. Would be nice if that could be integrated within the next update.

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Jan-Peter

    (@starguide)

    Hi Thomas,

    that is unfortunately for a reason: If you add noopener to the Facebook link you end up with a blank page after sharing. Therefore we excluded this for Facebook but not for the other buttons.

    Cheers
    JP

    Thread Starter Thomas A. Reinert

    (@thomas-a-reinert)

    Thanks for your quick reply, @starguide .
    I inspected the code after posting – wrong order, sorry for that. Found the exclusion and still wondered why. So thanks for the clarification.
    Still a pity – must be facebooks´ black magic not following html standards thats now hindering that site from getting a full hundred percent on googles lighthouse tools :/

    Plugin Author Jan-Peter

    (@starguide)

    Hi Thomas,

    I just tested it again, since I haven’t done it in a while. Well, it works fine if you use the pop-up setting (opening in a pop-up instead of a new tab). Without it you end up with this page after sharing: https://imgur.com/a/zS7GAPQ

    So not as bad any more, as it used to be. Mhm, thinking if it’s good enough to remove the exclusion? What do you think?

    Cheers
    JP

    Thread Starter Thomas A. Reinert

    (@thomas-a-reinert)

    Sorry for getting back so late, Jan-Peter. Was pretty involved inna project.. :/
    Well yes, it seems to work that way.

    Only problem is the contrast as you can see on https://ibb.co/bdqnL17
    I am using the “white”, “small”, “horizontal” Layout.

    Sidenote: Would you care if I – no promises involved in that case! – would push fixes to it in your repo?

    Plugin Author Jan-Peter

    (@starguide)

    Hi Thomas,

    against which standard are you testing? For sites that need to comply with the WCAG 2.1 we have the separate high contrast theme: “wcag”. I don’t want to change the standard white theme, since the high contrast colours are a lot different to the original ones. But maybe it would be a good idea to add another wcag-white theme that uses these colours.

    Which standards do you usually follow in regards to accessibility?

    Cheers
    JP

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘At least the facebook-button is missing a rel=”noopener”’ is closed to new replies.