Plugin Contributor
codejp3
(@codejp3)
Astra is a very popular/common theme. I think it makes more sense to ensure bbp Style Pack is compatible with it than to suggest random themes hoping you’ll be happy with them.
I’m not at my dev computer right now, but will be later today. I’ll install Astra theme and dig in to see what’s not compatible with the theme, and make changes to the plugin as needed.
@wbuser2022 – if you describe exactly what issues you had and what wasn’t working, it’ll help greatly!
Plugin Contributor
codejp3
(@codejp3)
@wbuser2022 – Got a chance to play around with Astra theme.
It is one of the very new FSE (full-site-editor) block themes that has already added internal integration with bbPress.
What that means is that you do NOT need to enable “Theme Support” for bbPress within Style Pack, since Astra theme has already done so.
The compatibility issue is because you DO have “Theme Support” enabled in wp-admin/options-general.php?page=bbp-style-pack&tab=bsp_block_theme and it is overwriting the fix that Astra theme has already implemented.
Disable that option in bbp Style Pack, and both bbPress & Style Pack will work fine with Astra theme. 😉
Marking as resolved, but will re-open this if you come back with any additional issues related to Astra theme.
@wbuser2022 – you can ignore this bit of the thread and as codejp3 says disable the theme support bit in the plugin and it should work fine
@codejp3 I’ve also been digging at the same time as you !
Presume we are both looking at the free Astra 4.0.2 theme by Brainstorm Force?
If so, this is a traditional WordPress theme, but does have a theme.json file, which is what we are currently using as the acid test for FSE themes. I done some research in the WordPress Developer docs, and ‘normal php’ themes can have this file, but it does affect their ability to use the classic editor.
Astra has this file, but also the normal php files and does not appear to be an FSE theme.
Looking further at the dev docs, the unique thing that an FSE theme must have is a templates directory with an index.html file, which won’t exist on an older php theme.
Unless you have other info, I will shortly change the test to
if ( file_exists( $theme_dir . '/templates/index.html') ) {
....
which should then work better.
Let me know if you agree (or not !!!) 🙂
Plugin Contributor
codejp3
(@codejp3)
@robin-w – makes perfect sense.
Perhaps checking for BOTH theme.json and /templates/index.html would narrow it down even more. By chance there may be traditional themes with one or the other, and checking for both would weed-out those false positives.
@codejp3 – I thought about that, but whilst many (maybe all) FSE themes will have a theme.json, it is not a WP requirement to have this. It is a req to have a /templates/index.html, and a traditional php theme will probably never have this, as you would only write this file if you are doing an FSE theme – at least that is my current understanding!
I’ll release this change shortly
Plugin Contributor
codejp3
(@codejp3)
@robin-w – sounds good. If we do discover any traditional themes that do have a /templates/index.html file, we can add an exception list to ignore those specific themes. Not needed now, but could be added easily if there any traditional themes reported that get counted as false positives in the future.
