Are all 7 calls to that process_link_element taking roughly the same amount of time? Or is one taking longer than the others? Do you have an external stylesheet loaded from another domain, for example?
Can you share a screenshot of the “Stylesheets” metabox on a validated URL screen?
Ideally expand the stylesheets for each <link> so we can see the URLs for the external stylesheets.
Alternatively, put your site into Transitional mode so we can see what the external stylesheets are.
Hi Danilo,
Thank you for these details, and apologies for the delay in getting back to you. We’re discussing this further with our team and will have an update soon.
Bethany
Hello @daniloparrajr
Can you please send your sites health information using this form, so we can investigate it further.
Hi @milindmore22,
I have submitted our site health information in the form, please check.
With regards to the stylesheet I manage to dequeue fontawesone and dashicons from the plugin calls, and optimize theme stylesheet by removing the unused styles we have in the site. Although that help in the site performance, AMP is still parsing the stylesheet slow. It is worth noting also that we don’t have Persistent object caching enable in our site because of Memberpress (our membership plugin) have issues with it.
Hello @daniloparrajr
Thanks for the update, I was wondering if you have any dynamic CSS implementation on your site, which includes dynamically-generated style rules with selectors referring to user IDs or elements being given randomized background colors. etc. it may invalidate the previous transient version and requires regeneration which may affect your performance.
Also, performance may degrade in terms of the number of CSS files, as you mentioned removing unused CSS is a good way to tackle it.
Alternatively, please check server timing log for amp_parse_css by passing ?amp_verbose_server_timing=1 while being logged in as Administrator. as shown in the screenshot it should be 0 meaning it’s being served from transient.
let me know if this helps.
Hi @milindmore22,
I checked the live site and amp_parse_css is not set to zero which concludes that the site it not serving from transient. Please know that the live site does not have object caching enable because of memberpress recommendation. Is there any way around this if we can’t use object caching?
Hello @daniloparrajr
thanks for the update, Using Object caching is recommended in such cases but given you can’t use object caching because of member press, I will recommend checking with member press plugin support.
memeberpress have this guide check if that’s helpful.
Alternatively, you can disable the AMP on pages that serve dynamic content.
Is there dynamic content though? All of the stylesheets being linked to seem to be static files. Are all of the external stylesheet URLs the same with each page load? Or are you adding a current timestamp as the version for any of them, causing them to change with each page load?
Hi @milindmore22,
Thank you for your suggestion, but I already implemented WP Rocket through the Memberpress guide you mentioned. I also disable AMP on memberpress pages.
Hello @westonruter,
There is a dynamic content but it is not changing every time a page is loaded so it is pretty much the same e.g. theme color settings.
## Are you adding a current timestamp as the version for any of them, causing them to change with each page load?
I’m not using current timestamp to version any of them.
Hello @daniloparrajr
Can you please compare your test page source with https://www.diffchecker.com/diff
the super guide section may be generating dynamic CSS.
can please check amp_parse_css after disabling it for some time?
https://prnt.sc/10bhjgc
https://prnt.sc/10bhjwj
I am finding variable content.
I did two requests to that URL and then pretty printed the HTML pages. Then I obtained a diff: https://gist.github.com/westonruter/9bfb597bd8bc2e5492b309f7b020ff97
The inline styles in particular may be causing the CSS parser to run. Nevertheless, these wouldn’t be involving process_link_element.
You may want to switch to Transitional mode temporarily to compare the AMP and non-AMP more easily to identify the change.
@westonruter @milindmore22
Ads are only showing for logged out users. I have checked amp_parse_css while logged in so ads that is adding inline styles won’t be present in the page. Also I have test a dev site where object caching is enable and it does show amp_parse_css is set to zero which means it is using the transient while in the staging and live site that have object caching disabled shows that amp_parse_css is not set to zero even on multiple page request.
The amp_parse_css should be 0 even when you are not using an external object cache. If not using an external object cache, then it uses transients. If the value is non-zero, then this indicates a cache miss with each request, or else that parsed CSS caching is disabled.
You can see the logic here: https://github.com/ampproject/amp-wp/blob/b5d3c6e457d06884e7f3847d0679be39657d401b/includes/sanitizers/class-amp-style-sanitizer.php#L1565-L1618
Notice the should_use_transient_caching method returns false if using an external object cache (if object-cache.php drop-in is present), or if the AMP plugin has disabled transient caching due to there being highly-variable CSS. In that case, the amp_css_transient_caching_disabled flag in the Site Health info would say true, but it is false for you so that doesn’t seem to be the case.
Perhaps you have a misconfigured object cache? Perhaps a wp-content/object-cache.php that is empty or not working?
-
This reply was modified 3 years, 6 months ago by
Weston Ruter.
-
This reply was modified 3 years, 6 months ago by Weston Ruter.
Hi @westonruter,
Object caching is working in the dev site which is just a copy of the live site. I have checked wp-content/object-cache.php and it’s not empty or misconfigured.
In order to further investigate the issue, I disabled plugins, change themes, and found out that the main theme CSS is not being cache by AMP. This file https://www.superguide.com.au/wp-content/themes/genesis-superguide/style.css?ver=4.1.0 is being parsed multiple times on every page load.
In order to get the logs of all not cached files I added an error_log here
https://github.com/ampproject/amp-wp/blob/b5d3c6e457d06884e7f3847d0679be39657d401b/includes/sanitizers/class-amp-style-sanitizer.php#L970-L972
You can see the debug.log content here – https://gist.github.com/daniloparrajr/c5e59d24a5ff7a3e3881da137e61e9dc
This is all the logs generated when the homepage is loaded.
