seeing the same thing as of the latest update
Same, rolled back using WP Rollback for the moment
@dccs52, @thinkforward, @rvsolutions – Good catch early, thanks for the fast report.
I think its related to our attempt to escape some outputs, but not sure we need to looking back on the content itself.
Can someone remove the esc_html() from this line and retest: https://github.com/PopupMaker/Popup-Maker/blob/master/includes/functions/popups/template.php#L42
Will push a patch with that removed as it wasn’t there before. Would love to know that it is the only regression change we need to make though so I’m not pushing update after update.
Just tried the removing the line highlighted,
https://github.com/PopupMaker/Popup-Maker/blob/master/includes/functions/popups/template.php#L42
It causes the popup to appear blank.
Our popup has CF7 in it, rolled back and works fine in previous version.
same thing here. even the inhouse newsletter subscription form function of the popupmaker outputs html text.
-
This reply was modified 2 months, 3 weeks ago by
CRE8.
Same issue… can someone please help with this ? My user cant login anymore.
Same here. Have now rolled back, but we have a LOT of clients using this plugin, so preparing for a busy day 🙁
Hey everyone, ok so I’m gonna revert these 2 changes as they are literally the only ones that can have any effect on popup rendering between current and last versions.
https://github.com/PopupMaker/Popup-Maker/commit/90c26c079f89a0538e9ea02857d9a60e460b4043
Would have loved to get a confirmation that reverting only the one on pum_popup_content function would fix it but without that confirmation from someone I’ll revert both and make a note to add back the other if someone does end up confirming that only one change is needed.
v1.16.7 is going out in the next few minutes which is a full reversion on front end changes. You may want to purge caches just to be safe as well.
Thanks for the quick response Daniel 🙂
@speedyp – Not a problem. I generally try to keep an eye on tickets within first few hours of any update we push. At the scale of our user base, problems tend to show up pretty quickly.
Appreciate the reports, would love some confirmations now that its out.
Also if anyone has the time to test it proper, I’d love to find out if we can leave 2 of the 3 escape functions in place. Not that they need it as they are mostly sanitized or generated content already, but WP Code Style scanner loves to highlight them otherwise.
-
This reply was modified 2 months, 3 weeks ago by
Daniel Iser.
@holdusback, @cre8gr, @dccs52, @thinkforward, @rvsolutions – Please try with the latest version (1.16.7).
Great! It works fine now!
@cre8gr – Thanks for the confirmation. Have a feeling it was just the content being ran through esc_html
Will wait a few day to see if everything is stable, for now I roll backed the folder from the version before
Plugin Support
Maria T
(@mariatogonon)
Hi @holdusback – we understand.
Just letting you know that we’ve received lots of users feedback and updating Popup Maker plugin to its latest version will now fix the issue.
We hope everything goes well for you.
Have a great day! 🙂
