Hi @oscowordpress1,
We have several integrations that help with ads on your site in combination with our plugin. With what do you serve your ads?
For example, AdSense or AdInserter as described in this article: https://complianz.io/integrating-with-ad-inserter-and-adsense/
If you use another tool, just let us know, and we can look into helping you with a solution.
Kind regards,
Kim van Dijk
@oscowordpress1 in 6.3.9 a change was merged which fixed an issue caused by the copying of data attributes in script elements, introduced in 6.3.6.
The fix was confirmed by two users who reported it, so if you still have issues it is something that hasn’t been reported yet, although your issue sounds as if it’s the same. But then 6.3.9 would solve it.
Can you share the domain so we can see the issue? We need to exclude any caching influence.
Thread Starter
OSCOWP
(@oscowordpress1)
I installed 6.3.9 hoping for that fix but nothing.
Here it’s the domain in question
https://www.cochespias.net/
@oscowordpress1 after accepting cookies, the ads show up for me (in the footer for example). After reloading the page, the ads stay in place. In the source I can see the ad scripts fired.
Is there something else I need to look at?
I realized this is the 6.3.5 version, I need to be able to view the issue live somehow, is that possible? As we can’t reproduce the issue, and have no other reports of this, this the only way to look into it.
Thread Starter
OSCOWP
(@oscowordpress1)
I’ll update to 6.3.9 on monday so you will be able to reproduce the issue but for me it didn’t work because of that.
Tried to rescan cookies, accepting them and nothing. As soon as I update my website on monday 2nd I’ll let you know
I have a better idea: I have created to branches: (1) doesn’t copy over script attributes to the new script element. If it works with this branch, and not with the 6.3.9 version, this would confirm the issue is the copying of attributes. If it still doesn’t work, it’s something else.
- https://github.com/Really-Simple-Plugins/complianz-gdpr/tree/without-script-attributes-copy
Script (2) does use the copying of attributes, but logs the attributes which are copied. That will tell us which attributes are copied, and we can then try to exclude some of them.
2. https://github.com/Really-Simple-Plugins/complianz-gdpr/tree/logging-of-attributes
If you can check
- with (1) if the script attributes are the issue.
- with (2) which attributes are copied
That should tell me in which direction to look.
Thread Starter
OSCOWP
(@oscowordpress1)
Hi!
I’m going to check both and I’ll let you know.
Thanks for your work in advance
Thread Starter
OSCOWP
(@oscowordpress1)
Hi!!
Version 1 worked perfectly, now my website its working with that one with no problems!
This one worked 💪🏽
- https://github.com/Really-Simple-Plugins/complianz-gdpr/tree/without-script-attributes-copy
Thanks for your help
@oscowordpress1 Thanks for checking! As the copying of data attributes is essential for other scripts, I can’t just drop that from the plugin. But your test tells me that there’s one attribute that is causing the issue. I checked, and you have two attributes that are still copied over: async, and crossorigin. I don’t expect crossorigin to be the problem, so my guess would be the async.
This branch does copy over the attributes, but not the async one. Can you check if this also works? If not, I can also drop the crossorigin, but prefer to check first the async.
https://github.com/Really-Simple-Plugins/complianz-gdpr/tree/logging-of-attributes
If that works, it will get merged in the next release, so you can keep updating.
@oscowordpress1 did you have the chance to check this?
