Support » Requests and Feedback » add flic.kr oEmbed support as a variant of flickr
4 years, 2 months ago
I found that flickr (http://www.flickr.com/) has its own short url domain flic.kr, but not yet supported by wordpress oembed mechanism.
how about add one line in wp-includes/class-oembed.php oembed_providers ?
‘#http://flic.kr/*’ => array( ‘http://www.flickr.com/services/oembed/’, false ),
We have youtube, why not this 🙂
flic.kr not providing https, so your patch might not working …
btw, you use regex but not set the 3rd arg as ‘true’ … :p
That’s what happens when you try to listen to your mother talk about how her printer broke while coding. Fixed and uploaded a better patch.
If you’re interested in writing patches, check out http://make.wordpress.org/core/handbook/
not working again…
‘#http://flic.kr/.*’ <- this is a regex but not complete ? but you said ‘false’ as the 3rd arg
why not just use my patch 🙂
‘http://flic.kr/*’ => array( ‘http://www.flickr.com/services/oembed/’, false ),
Because you didn’t submit a patch. You left a comment. If you want to submit a patch, you need to read http://make.wordpress.org/core/handbook/ and actually submit a patch file.
You can totally do this too 🙂
Here’s what a finished patch looks like: http://core.trac.wordpress.org/attachment/ticket/23052/23052-3.diff
BTW: I copied what you had in your first post.