Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Contributor Heateor Support

    (@heateor)

    Sorry about it. We will take care of this in upcoming updates.

    As a suggestion, maybe adding the title attribute would solve the problem, at least in the part of sharing services. The list of sharing networks works fine, the sharing services show checkboxes without any label, and the rearrange list simply looks like as a blank cell spanning two columns.
    I tried to solve it, and it works, partially.
    I changed the type of the input for the rearranging section from hidden to checkbox. It works, but there is a little problem. The user must check all inputs in this section both in the standard and floating tab, every time before saving the changes. If the checkboxes in this section are unchecked when the Save changes button is clicked, these services/network are removed from the list of selected links/buttons to appear and the user must add them again. It’s probably my fault, because I’m not an experienced developer. It’s just a temporary tweak, somewhat tricky at usage time, but functioning. Maybe it could give an idea about a proper solution. 🙂 Here are the changes I made:

    • Standard theme (admin/social_sharing.php:1699)
      <input type="checkbox" name="the_champ_sharing[horizontal_re_providers][]" value="<?php echo $rearrange ?>" title="<?php echo ucfirst(str_replace('_', ' ', $rearrange)) ?>">
    • Floating theme (admin/social_sharing.php:2451)
      <input type="checkbox" name="the_champ_sharing[vertical_re_providers][]" value="<?php echo $rearrange ?>" title="<?php echo ucfirst(str_replace('_', ' ', $rearrange)) ?>">

    Now, about the sharing services, it’s pretty similar, but somewhat different. The label is printed beside the image in the label tag. I tried putting it in the alt attribute, as a title attribute in the input, but for some reason it didn’t work for me. Maybe you can find the way to implement it there, since this variant probably changes the visual aspect – I’m blind so I’m not sure about it. 😀

    • Standard theme (admin/social_sharing.php:1777)
      <label for="the_champ_<?php echo $likeButton ?>"><img src="<?php echo plugins_url('../images/sharing/'. $likeButton .'.png', __FILE__) ?>" /><?php echo ucfirst(str_replace('_', ' ', $likeButton)); ?></label>
    • Floating theme (admin/social_sharing.php:2527)
      <label for="the_champ_vertical_<?php echo $likeButton ?>"><img src="<?php echo plugins_url('../images/sharing/'. $likeButton .'.png', __FILE__) ?>" /><?php echo ucfirst(str_replace('_', ' ', $likeButton)); ?></label>

    I will look at the user/display part, and tell you if I find at least a temporary solution. 🙂

    Hope this helps 🙂

    Plugin Contributor Heateor Support

    (@heateor)

    Thanks for the details. Will keep it in mind.

    Great! 😀

Viewing 4 replies - 1 through 4 (of 4 total)
  • You must be logged in to reply to this topic.