A little validation bug and a question about per product activating

  • Resolved Daniel Mesteru

    (@daniel-mesteru)


    7 years, 5 months ago

    Hello,

    Great work here, but I have some questions/feedback.
    I’m using the latest version of WP with the Woothemes Storefront theme.

    1. First, where I think it is a bug:
    When the “Display on Cart” is selected and the “Make upload field required option is set to yes”, the validation doesn’t occur and the customer can proceed to the next step. This shouldn’t be alowed.
    When the “Display on Checkout Page” is selected and the “Make upload field required option is set to yes”, the validation works flawlessly. So this works correctly.

    2. Second, how can this option be activated at product level? I don’t want to make it a required field website wide, I want to make the upload option required for just a product. Actually, I only have a product where I want to permit to upload a kind of file.

    If you could bring a shade of light on this one, it would be great.

    Thanks,
    Daniel

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Fahad Mahmood

    (@fahadmahmood)

    7 years, 5 months ago

    Hi Daniel,

    Your suggestion is really good and i will surely work on it.

    Thanks,
    Fahad

    Plugin Author Fahad Mahmood

    (@fahadmahmood)

    7 years, 5 months ago

    Please check v.1.0.8 for validation improvements, i will work further on product specific suggestion.

    Thread Starter Daniel Mesteru

    (@daniel-mesteru)

    7 years, 5 months ago

    Hi Fahad,

    Great work and thank you for the prompt answer, too bad that the e-mail from the WP platform got in spam, I would have answered more rapidly.
    Good job for making available a customized error message field in the plugin admin.

    Your new validation works, but the error message is not applied correctly.
    I’ll try to describe this issue as clearly as possible:

    Now when the “Display on Cart” is selected and the “Make upload field required option is set to yes”, the validation does occur and the customer can’t proceed to the next step. This is OK.
    But still a bug here, the error message set in admin doesn’t appear. When I press “Proceed to Checkout” the validation works (I can’t go further), but no error message is displayed.

    So, I now have the “Browse” option as “Required” on the Cart page, I input the required file, and I proceed to next step which is the Checkout page. Here, when I try to place the order, I receive an error message requesting the required file, but I don’t see the browse button anymore (because it is on the Cart page). 🙂

    This now works as it should as per validation on Cart but still the validation message is passed to the checkout page instead of cart. Something is mixed up.

    When the “Display on Checkout Page” is selected and the “Make upload field required option is set to yes”, the validation works without a problem (the validation works and the order can’t be placed before uploading a file). This is OK.

    Can’t wait for the product specific option, it would be a great add-on.

    Regards,
    Daniel

    Plugin Author Fahad Mahmood

    (@fahadmahmood)

    7 years, 5 months ago

    I got it. Validation is working fine but message is not appearing on correct position at correct time. I wills surely check it. Thank you.

    Plugin Author Fahad Mahmood

    (@fahadmahmood)

    7 years, 5 months ago

    It took a couple of hours because woocommerce action hooks are not working in that way. I tried to manage it with request_uri. Give it a try and let me know if it’s good now?

    Thread Starter Daniel Mesteru

    (@daniel-mesteru)

    7 years, 5 months ago

    Hello,

    The validation works now, but no error/info message is displayed on “Cart” page. The customized message set in admin doesn’t appear. I’ve tried without my custom message also and it isn’t working.

    Thanks,
    Daniel

    Thread Starter Daniel Mesteru

    (@daniel-mesteru)

    7 years, 5 months ago

    Sorry to be a pain but I’ve tested the checkout page and now the validation isn’t working here.

    When the “Display on Checkout” is selected and the “Make upload field required” option is set to yes, the validation doesn’t occur and the customer can place the order…

    Plugin Author Fahad Mahmood

    (@fahadmahmood)

    7 years, 5 months ago

    Strange, i will check it again. But this time i need your website URL as well because it’s always good to check in real scenario.

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘A little validation bug and a question about per product activating’ is closed to new replies.