A list of issues and enhancements

  • Resolved frenchomatic

    (@frenchomatic)


    6 years, 8 months ago

    Here are a number of issues, problems or things that I have found. Some are simple to fix, some I have overcome in the functions.php file and some have required hardcoded customization of the plugin (really bad practice).

    I want to put this all in one post. Some feedback from the plugin developers about these would be appreciated. One or two of the issues have been replied to but some times-scales would be nice.

    It is an excellent plugin, it is nearly there but it does need some enhancements and a few things fixed.

    Issue 1: alt tag on logo
    Issue 2: archive title and archive description should be replaced by genesis headline / description.
    Issue 3. thumbnails on archive & taxonomies need alt tags
    Issue 4. use of genesis document title / meta description for AMP title tag and meta description.
    Issue 5. links on menu should use the canonical url (i.e. slash on the end in most cases).
    Issue 6. If a new AMP front-page (static) is defined (i.e. can’t use the existing home page because it is widgetized) then the canonical url and amphtml need to align properly on the home page. Also comments link keeps showing on the static ‘home’ page.
    Issue 7. Trailing slash on amp urls is often missing
    Issue 8: Analytics – should be an admin option to remove the action completely – google reports errors if the script is left in the head but nothing is defined.
    Issue 9. usemetadata(1) doesn’t appear to work robustly – it starts putting in admin for the publisher.
    Issue 10. nice to have a setting for the length of excerpts as opposed to making a hardcode setting
    Issue11. author / date not appearing on blog posts page.
    Issue 13. On posts page the author and date doesn’t show.
    14. If you are using a static front page which is widgetized then it would be really nice to allow a featured image to be added just to the AMP version without it showing up on the non-AMP version. If this could be done then 6 is no longer an issue.

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Contributor ampforwp

    (@ampforwp)

    6 years, 8 months ago

    Hi @frenchomatic,

    Thank you so much for all your suggestions. Me and my team appreciate it a lot.

    I have created a ticket for this list. ref: https://github.com/ahmedkaludi/accelerated-mobile-pages/issues/1013

    We will add this in our next update.

    Regards
    Marqas

    Thread Starter frenchomatic

    (@frenchomatic)

    6 years, 8 months ago

    Thank you – I did send you a genesis test environment but I have heard nothing back to acknowledge that you have it.

    Thread Starter frenchomatic

    (@frenchomatic)

    6 years, 8 months ago

    There is one more feature worthy of mentioning: it is bound to be a bit complicated or may be not.

    Would it be possible to discover if a link embedded within an AMP page goes to a page which has an AMP version. Some type of toggle to say go to an AMP version of the linked page if it exists.

    This would be a really nice feature – especially for those making complete AMP versions of their web site. Perhaps some type of filter on the content could be added.

    Cloudflare does something like this between domains but it doesn’t do it within a domain.

    Plugin Contributor ampforwp

    (@ampforwp)

    6 years, 8 months ago

    Hi @frenchomatic,

    We already have that in our mind, but it is not easy as it looks.

    I guess we have to make a separate sanitizer to do this task, but as you can see there is a very less request for that, may be two or three.
    But I will discuss with my team and try to figure a way out.

    And regarding the above-listed issues, you said this: Issue 9. usemetadata(1) doesn’t appear to work robustly – it starts putting in admin for the publisher.

    Can you explain it more clearly, I tried the things from my understanding but that is working fine on my end. If you can explain me in details what the issue is and where it is coming, I will check it and fix it right away.

    Regards
    Marqas

    Plugin Contributor ampforwp

    (@ampforwp)

    6 years, 8 months ago

    Hi @frenchomatic,

    Can you please explain me the issue about the date/author not appearing in blog posts page.

    Following are the links to the screenshots, where the Date/author

    http://take.ms/ejK7k
    http://take.ms/IaB9r

    I could be wrong so could you please explain me with the help of screenshots so I can understand properly and resolve the issue.

    We’d like to release our new update by Saturday so it would be really helpful to us if you explain it today.

    Regards
    Mohammed Asif

    Thread Starter frenchomatic

    (@frenchomatic)

    6 years, 8 months ago

    On design 2 – on the main blog posts page it is not putting in the author or date. You can see it on the test domain that I sent – articles page. However it of course shows on the non-amp version.

    The second issue is this code below – for some reason it is always going to admin on one of my domains (not on the test site though). I need to find out why and report back. It is probably something to do with how the pages were orgnially published. The display name or nic name in the wp admin panel is certainly not admin .

    $structured_data_author = get_userdata( 1 );
    if ( $structured_data_author ) {
    $structured_data_author = $structured_data_author->display_name ;
    } else {
    $structured_data_author = “admin”;
    };

    Thread Starter frenchomatic

    (@frenchomatic)

    6 years, 8 months ago

    All this has made it onto your github list. Thank you.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘A list of issues and enhancements’ is closed to new replies.