A few 0.10.2 issues

  • Resolved taylorsellers

    (@taylorsellers)


    1 year, 10 months ago

    Thank you so much for the 0.10 update. The loading bar is so nice to have! I have noticed a few issues though:

    1. The buttons don’t play nicely with narrow screens, like a mobile phone in portrait.

    Ideally, a way to choose which buttons appear would be great. As a site focusing on radiographs, I’d love the ability to hide the orientation button, the ruler, and the “user selection” dropdown menu.

    2. The viewer now creates grey space around the radiograph which limits the size of the image.

    Previously the radiograph would have filled the width of the viewer and scaled up the vertical dimension of the viewer to include the whole image. This also creates some weird behavior in Fullscreen mode where the image does not actually fill the whole screen vertically, and creates black bars on the top and bottom instead.

    Thanks again, your work on DWV and the WordPress plugin are so appreciated!

    The page I need help with: [log in to see the link]

Viewing 14 replies - 1 through 14 (of 14 total)
  • Plugin Author ivmartel

    (@ivmartel)

    1 year, 10 months ago

    Thanks for you feedback!

    1. got it for the narrow screens and choose buttons, I’ll see what I can do. The ‘user selection’ is a list of window level presets that come with the dicom, it’s true it seems empty in most of your cases.
    2. the grey space is the space in which you can pan/zoom. This space was narrower before and was black in full screen, so harder to see. It’s a way for me to see it, I’ll look into making it transparent again
    Thread Starter taylorsellers

    (@taylorsellers)

    1 year, 10 months ago

    Awesome, thanks! It’s not the color of the extra space that is problematic. It probably should be grey so you can see the edge of the image if you pan it outside the field of view. I’m mostly not understanding why making the working area a different size and shape than the image being displayed is advantageous. Even with cross sectional imaging every slice has the same dimensions. Making the working area the same size as the image will then maximize the size of the image regardless of display size and orientation.

    Plugin Author ivmartel

    (@ivmartel)

    1 year, 10 months ago

    Having a larger working area gives you more space to zoom and pan. It allows to use the full screen instead of just the initial fit to data area. The black background, since it is the same as the data background, could give you the impression that the full screen was available when it was not.

    This width is customizable, by default it is set to 100% but you can set it smaller if you want (in % or pixels).

    Thread Starter taylorsellers

    (@taylorsellers)

    1 year, 10 months ago

    oh, great! How do I change it? I didn’t think this plugin had a settings menu.

    Plugin Author ivmartel

    (@ivmartel)

    1 year, 10 months ago

    The setting is available when you write a post, from the right setting panel. I made an error in my previous answer, its value is in pixels.

    Plugin Author ivmartel

    (@ivmartel)

    1 year, 10 months ago

    Just to be clear, the grey zone that you see at startup:

    …is a zone that is now available for zoom and pan, you can fill it with the image and it will give you:

    The previous version of the plugin with the same zoom gave something like:

    A larger work zone is preferable, isn’t it?

    Reverting the background color to transparent would be easy for me, it will look like it was before while having a larger zone. It is maybe simpler than you setting the image width for all posts.

    Thread Starter taylorsellers

    (@taylorsellers)

    1 year, 10 months ago

    The previous version worked a little differently than your mockup. It automatically filled the whole width of the window with workable space (like your second image) but it also extended the working area vertically so the entire radiograph was visible. The end result was a very large working area (larger than the current version), with the radiograph completely filling it.

    I don’t think I have a screenshot of this saved, unfortunately. I’m not sure if it’s possible to roll back the plugin version and take some, but I can check later when I’m off of work.

    Plugin Author ivmartel

    (@ivmartel)

    1 year, 10 months ago

    To rollback, I use https://wordpress.org/plugins/wp-rollback/

    It’s true the height is now 500px by default, I’ll look into it.

    Thread Starter taylorsellers

    (@taylorsellers)

    1 year, 10 months ago

    Thanks for the tip on the rollback plugin. I rolled back to 0.9 if you want to see the previous behavior. I also took a screenshot. I zoomed way out to show the whole xray, but you can see how it automatically fills the width of the frame and extend vertically to show the whole image. This is the preferred behavior for my use case at least.

    Thanks again for your attention to this!

    Plugin Author ivmartel

    (@ivmartel)

    1 year, 10 months ago

    I published a few versions yesterday… The latest being v0.10.5. It should fix the ‘grey space’ problem: by default, if you do not specify a width or height, the viewer will use 100% of the width and stretch the height accordingly. Please tell me how it goes and if this is what you are expecting.

    The toolbar now wraps if the size of the screen is too small but, in some cases, the image overlaps on the text if there is any after it… To check…

    Thread Starter taylorsellers

    (@taylorsellers)

    1 year, 10 months ago

    Amazing update, thank you! This is exactly what I was hoping for. I really appreciate it. I have a few very minor suggestions, but they aren’t particularly important.

    • Full screen mode isn’t truly full screen. My guess is that the grey working area is trying to maintain a specific aspect ratio, so when it reaches its horizontal limit it no longer expands vertically so there is a large black bar inferiorly on my monitor
    • The loading bar is green. Not sure if that is an issue with my theme or not.
    • Ability to hide unwanted buttons would be amazing

    Again, these are really minor. Thanks again for your work!

    Plugin Author ivmartel

    (@ivmartel)

    1 year, 10 months ago

    v0.10.6 should fix the full screen. It also sets the background to black on full screen.

    Regarding the green loading bar, I guess it is related to your theme. The viewer uses a regular html ‘progress’ (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress).

    I created an issue for the tools customisation (https://github.com/ivmartel/dwv-wordpress/issues/28). There’s quite a bit of work, not sure when I’ll have time to work on it.

    Plugin Author ivmartel

    (@ivmartel)

    1 year, 9 months ago

    I hope everything is ok with the latest version. If you are happy, can you close this thread please?

    Thread Starter taylorsellers

    (@taylorsellers)

    1 year, 9 months ago

    Sorry, yes thank you the latest release is great.

Viewing 14 replies - 1 through 14 (of 14 total)

The topic ‘A few 0.10.2 issues’ is closed to new replies.