[Plugin: Widgetize Pages Light] Please stop changing WP core files!

  • Resolved David Decker

    (@daveshine)


    11 years, 8 months ago

    Hi there!
    I just found out that your plugin replaces functions names from WordPress core files and manipulates the file “wp-includes/widgets.php”.

    This ist totally against best practices and WordPress coding standards. One should never ever touch core files.

    It leads to breaking functionality with themes and/or other plugins. What is with plugins relying on the function “is_active_sidebar”?

    I hope you could release an update of your plugin which changes the code this way that all ins in your plugin and that it never touches any core files.

    Aren’t the hooks/filters of WordPress enough for modular plugins? Just wondering…?

    Thanks, Dave 🙂

    http://wordpress.org/extend/plugins/widgetize-pages-light/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author OTWthemes

    (@otwthemes)

    11 years, 8 months ago

    We are against changing WordPress core files. Definitely not a good practice. Unfortunately WordPress does not provide the necessary filters.

    The changes do not affect or brake the work of themes or other plugins. No issues there.

    Once deactivated the plugin will return everything just the way it was before activation.

    We will continue to follow WordPress core updates and if the proper filters are added we will update our plugin.

    Bottom line:
    – Yes changing files is bad practice, in this case there is no other option.
    – It does not affect other themes and plugins.
    – Once WordPress make it possible we will do an update of our plugin.

    Regards,
    OTWthemes

    Plugin Author OTWthemes

    (@otwthemes)

    11 years, 3 months ago

    The whole activation and replacement process/logic has been changed. No core files are being modified.

    Note: Manually updating to versiion 1.5. requires deactivation of the old version first. If you are using the wordpress updater it will do all the job for you.

    OTWthemes

    lakenjr

    (@lakenjr)

    11 years, 3 months ago

    Thanks for developing this most useful plugin. Unfortunately my website crashed with Fatal error: Call to undefined function is_active_sidebar()

    After much anguish, I eventually fixed the problem painlessly by reinstalling WordPress (which replaces the core files).

    My problem occurred when I updated from v1.4 to v1.5

    I updated by viewing details of the latest changes to the plugin and then clicking install now. Maybe this method did not deactivate the old version first. For the benefit of others please recheck this and display a suitable warning.

    http://www.jetlagandmayhem.com

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘[Plugin: Widgetize Pages Light] Please stop changing WP core files!’ is closed to new replies.