Hi there, many apologies, I hadn’t seen your message. Yes, this plugin has recommenced development. I have just uploaded version 1.0, which brings in the latest mobile devices (including iPad, Android Tablets, etc) through the Mobile ESP project. I have liaised with the Mobile ESP to develop this update to the plugin, and intend to keep it up to date as the Mobile ESP updates its detection code.
I am also implementing some basic image transcoding, and intend to add a sample theme based on the Mobile Boilerplate project.
Do you have any other ideas?
By the way – check out version 1.1 of the Mobile Smart plugin. Hope this helps. Any feedback welcomed.
Best…Dan
Hi Dan,
I found an error which made it impossible to generate resized images. It is on line 876 in mobile-smart.php, MOBILESMART_PLUGIN_URL should be MOBILESMART_PLUGIN_PATH, I think you forgot to change.
Also, I have changed the slash and WP_PLUGIN_DIR into WP_PLUGIN_URL on line 40, from:
define('MOBILESMART_PLUGIN_PATH', WP_PLUGIN_DIR . '\mobile-smart'); to
define('MOBILESMART_PLUGIN_URL', WP_PLUGIN_DIR . '/mobile-smart');
After these changes, the images are finally resized, but only for the images uploaded in WordPress, not external images. I think it’s because on line 833 you defined $site_url to search for get_bloginfo only. Other than this, the dimensions of the images aren’t resized correctly as well.
As I am not sure how to fix this, I decided to replace all the image resize code in mobile-smart.php with another image resize code I copied from another plugin.
I don’t know how to contact you, so I try this way, hope you read it.
Anyways, Mobile Smart is a very good plugin, keep up the good work!
Hi Lizzious,
This forum is the right place to contact me – thanks for your message.
Thanks for checking through the code – I’ll investigate your findings and release a bug fix as necessary. The code for the image transcoding is still in development, so this is the right time to raise these concerns.
When you mention resizing external images, are these ones that have been added to the post/page via the image attachment box, or directly into the HTML? I must admit that I’d not considered the use case of external images, and was only handling uploaded images.
When you say the dimensions of the images aren’t resized correctly – is that they lose their aspect ratio (e.g. stretched/squashed), or that the image is scaled to the wrong width for the mobile device?
Lots of questions, just to help me move this forward.
Many thanks,
Dan
Hi Dan,
I didn’t expect you to reply me so fast. Good to hear you’re paying attention to your plugins, unlike some other plugin authors. Okay, let’s answer your questions.
With ‘external’ images I mean the images hosted elsewhere, images that are not uploaded using WordPress media uploader (into the folder wp-content/uploads/). For example Google’s logo (http://www.google.nl/images/logos/ps_logo2.png).
Whether you add it to the post via the image attachment box or directly into html make no difference. People can add it via ‘Add media file from URL’ in the media uploader or just write <img src="http://www.google.nl/images/logos/ps_logo2.png">. Both won’t work. Not only are the external images not resized, they won’t display at all.
Yes, the images lose their aspect ratio, as well as scaled to the wrong width for mobile devices. This has nothing to do with timthumb, as I’ve tested it by removing timthumb from the code. The image width and height (<img width="" height="") are wrong.
The code I copied from another plugin and pasted into Mobile Smart works perfectly. I will upload the new mobile-smart.php page somewhere so you can check it out.
Thanks for your feedback lizzious, that’s clarified all the issues for me.
It looks like the transcoding part needs a bit more work, though I’m about to use it on a live site for a client, so I will work on this in order to get his site working properly. Hopefully I will be able to release an update in the near future – apologies for code that’s not completely working.
Feel free to email me the new version of the .php file to dan (at) dansmart.co.uk
All the best,
Dan
