Support » Plugin: Theme My Login » 4 patches available

  • I don’t know how you want patches but I have 4 patches available:

    1. Redirect of logout is wrong.
    2. Resolve deprecated functions. One is deprecated per WordPress 3.8 but the others are deprecated prior to WordPress3.7
    3. Small typo in documentation
    4. Function does echo, no need for echo statement.

    Let me know how to hand you those patches.

    Peter van der Does

    https://wordpress.org/plugins/theme-my-login/

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Jeff Farthing

    (@jfarthing84)

    You could’ve posted them right here or e-mail me: jeff [at] jfarthing [dot] com.

    Redirect of logout is wrong.

    diff --git a/includes/class-theme-my-login.php b/includes/class-theme-my-login.php
    index 23e6aa5..e72434a 100644
    --- a/includes/class-theme-my-login.php
    +++ b/includes/class-theme-my-login.php
    @@ -653,7 +653,7 @@ if(typeof wpOnload=='function')wpOnload()
     	public function logout_url( $logout_url, $redirect ) {
     		$logout_url = self::get_page_link( 'logout' );
     		if ( $redirect )
    -			$logout = add_query_arg( 'redirect_to', urlencode( $redirect ), $logout_url );
    +            $logout_url = add_query_arg( 'redirect_to', urlencode( $redirect ), $logout_url );
     		return $logout_url;
     	}

    Resolve deprecated functions. One is deprecated per WordPress 3.8 but the others are deprecated prior to WordPress 3.7. Screen Icon is deprecated per WordPress 3.8.

    admin/class-theme-my-login-admin.php                          | 3 +--
     modules/custom-email/admin/custom-email-admin.php             | 1 -
     modules/custom-redirection/admin/custom-redirection-admin.php | 1 -
     modules/custom-user-links/admin/custom-user-links-admin.php   | 1 -
     4 files changed, 1 insertion(+), 5 deletions(-)
    
    diff --git a/admin/class-theme-my-login-admin.php b/admin/class-theme-my-login-admin.php
    index fd95efc..6d2b301 100644
    --- a/admin/class-theme-my-login-admin.php
    +++ b/admin/class-theme-my-login-admin.php
    @@ -132,7 +132,6 @@ class Theme_My_Login_Admin extends Theme_My_Login_Abstract {
     		) ) );
     		?>
     		<div id="<?php echo $options_key; ?>" class="wrap">
    -			<?php screen_icon( 'options-general' ); ?>
     			<h2><?php echo esc_html( $title ); ?></h2>
     			<?php settings_errors(); ?>
    
    @@ -244,7 +243,7 @@ class Theme_My_Login_Admin extends Theme_My_Login_Abstract {
    
     		// Check if legacy page exists
     		if ( $page_id = $this->get_option( 'page_id' ) ) {
    -			$page = get_page( $page_id );
    +			$page = get_post( $page_id );
     		} else {
     			$page = get_page_by_title( 'Login' );
     		}
    diff --git a/modules/custom-email/admin/custom-email-admin.php b/modules/custom-email/admin/custom-email-admin.php
    index 096d83f..11698ef 100644
    --- a/modules/custom-email/admin/custom-email-admin.php
    +++ b/modules/custom-email/admin/custom-email-admin.php
    @@ -146,7 +146,6 @@ class Theme_My_Login_Custom_Email_Admin extends Theme_My_Login_Abstract {
     		global $current_screen;
     		?>
     		<div class="wrap">
    -			<?php screen_icon( 'options-general' ); ?>
     			<h2><?php echo esc_html_e( 'Theme My Login Custom E-mail Settings', 'theme-my-login' ); ?></h2>
     			<?php settings_errors(); ?>
    
    diff --git a/modules/custom-redirection/admin/custom-redirection-admin.php b/modules/custom-redirection/admin/custom-redirection-admin.php
    index b221d43..03c5bad 100644
    --- a/modules/custom-redirection/admin/custom-redirection-admin.php
    +++ b/modules/custom-redirection/admin/custom-redirection-admin.php
    @@ -130,7 +130,6 @@ class Theme_My_Login_Custom_Redirection_Admin extends Theme_My_Login_Abstract {
     		global $current_screen;
     		?>
     		<div class="wrap">
    -			<?php screen_icon( 'options-general' ); ?>
     			<h2><?php echo esc_html_e( 'Theme My Login Custom Redirection Settings', 'theme-my-login' ); ?></h2>
     			<?php settings_errors(); ?>
    
    diff --git a/modules/custom-user-links/admin/custom-user-links-admin.php b/modules/custom-user-links/admin/custom-user-links-admin.php
    index 80fb2e1..0843ff4 100644
    --- a/modules/custom-user-links/admin/custom-user-links-admin.php
    +++ b/modules/custom-user-links/admin/custom-user-links-admin.php
    @@ -141,7 +141,6 @@ class Theme_My_Login_Custom_User_Links_Admin extends Theme_My_Login_Abstract {
     		global $current_screen;
     		?>
     		<div class="wrap">
    -			<?php screen_icon( 'options-general' ); ?>
     			<h2><?php echo esc_html_e( 'Theme My Login Custom User Links Settings', 'theme-my-login' ); ?></h2>
     			<?php settings_errors(); ?>

    Small typo in documentation

    modules/custom-user-links/admin/custom-user-links-admin.php | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/modules/custom-user-links/admin/custom-user-links-admin.php b/modules/custom-user-links/admin/custom-user-links-admin.php
    index 0843ff4..29334e8 100644
    --- a/modules/custom-user-links/admin/custom-user-links-admin.php
    +++ b/modules/custom-user-links/admin/custom-user-links-admin.php
    @@ -219,7 +219,7 @@ class Theme_My_Login_Custom_User_Links_Admin extends Theme_My_Login_Abstract {
     	 *
     	 * @param array $link Link data
     	 * @param string $role Name of user role
    -	 * @return sring Link row
    +	 * @return string Link row
     	 */
     	private static function get_link_row( $link, $role ) {
     		$r = '';

    Function does echo, no need for echo statement.

    modules/custom-email/admin/custom-email-admin.php             | 2 +-
     modules/custom-redirection/admin/custom-redirection-admin.php | 2 +-
     modules/custom-user-links/admin/custom-user-links-admin.php   | 2 +-
     3 files changed, 3 insertions(+), 3 deletions(-)
    
    diff --git a/modules/custom-email/admin/custom-email-admin.php b/modules/custom-email/admin/custom-email-admin.php
    index 11698ef..23afe6a 100644
    --- a/modules/custom-email/admin/custom-email-admin.php
    +++ b/modules/custom-email/admin/custom-email-admin.php
    @@ -146,7 +146,7 @@ class Theme_My_Login_Custom_Email_Admin extends Theme_My_Login_Abstract {
     		global $current_screen;
     		?>
     		<div class="wrap">
    -			<h2><?php echo esc_html_e( 'Theme My Login Custom E-mail Settings', 'theme-my-login' ); ?></h2>
    +			<h2><?php esc_html_e( 'Theme My Login Custom E-mail Settings', 'theme-my-login' ); ?></h2>
     			<?php settings_errors(); ?>
    
     			<form method="post" action="options.php">
    diff --git a/modules/custom-redirection/admin/custom-redirection-admin.php b/modules/custom-redirection/admin/custom-redirection-admin.php
    index 03c5bad..79c65ae 100644
    --- a/modules/custom-redirection/admin/custom-redirection-admin.php
    +++ b/modules/custom-redirection/admin/custom-redirection-admin.php
    @@ -130,7 +130,7 @@ class Theme_My_Login_Custom_Redirection_Admin extends Theme_My_Login_Abstract {
     		global $current_screen;
     		?>
     		<div class="wrap">
    -			<h2><?php echo esc_html_e( 'Theme My Login Custom Redirection Settings', 'theme-my-login' ); ?></h2>
    +			<h2><?php esc_html_e( 'Theme My Login Custom Redirection Settings', 'theme-my-login' ); ?></h2>
     			<?php settings_errors(); ?>
    
     			<form method="post" action="options.php">
    diff --git a/modules/custom-user-links/admin/custom-user-links-admin.php b/modules/custom-user-links/admin/custom-user-links-admin.php
    index 29334e8..ef52912 100644
    --- a/modules/custom-user-links/admin/custom-user-links-admin.php
    +++ b/modules/custom-user-links/admin/custom-user-links-admin.php
    @@ -141,7 +141,7 @@ class Theme_My_Login_Custom_User_Links_Admin extends Theme_My_Login_Abstract {
     		global $current_screen;
     		?>
     		<div class="wrap">
    -			<h2><?php echo esc_html_e( 'Theme My Login Custom User Links Settings', 'theme-my-login' ); ?></h2>
    +			<h2><?php esc_html_e( 'Theme My Login Custom User Links Settings', 'theme-my-login' ); ?></h2>
     			<?php settings_errors(); ?>
    
     			<form method="post" action="options.php">
    Plugin Author Jeff Farthing

    (@jfarthing84)

    Thanks! I plan to move development to Github soon, so user participation will be easier!

    Awesome, love github.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘4 patches available’ is closed to new replies.