Support » Plugin: Kirki » 3.0.26 is Killing ALL of Fontawesome

  • Resolved ThemeAWESOME

    (@tsquez)


    Hi there,

    Just wanted you to know that your new update does something to Font Awesome.

    I load Font Awesome myself, separate of Kirki, and after I updated, all of my font awesome icons disappeared. So I went back to 3.0.25 and they reappeared again.

    Had some other people using my theme have sent me messages telling me the same thing.

    So something is def wrong with the update.

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Aristeides Stathopoulos

    (@aristath)

    which theme is that?

    Plugin Author Aristeides Stathopoulos

    (@aristath)

    And where exactly are the icons missing?

    TotalPress – https://wordpress.org/themes/totalpress/

    LOL so your gonna say its a theme issue? j/K

    OK, look,

    everything was running fine until I updated Kirki this morning.

    I load FA in the header. I have icons in a widget in the header of my site http://themeawesome.com

    After i updated to 3.0.26 the icons Disappeared, I switched back to 3.0.25 the icons came back.

    Plugin Author Aristeides Stathopoulos

    (@aristath)

    LOL so your gonna say its a theme issue? j/K

    I didn’t say that… I only asked because in order to understand what went wrong, debug it and fix it, first I need to replicate the issue.

    I load FA in the header. I have icons in a widget in the header of my site http://themeawesome.com

    After i updated to 3.0.26 the icons Disappeared, I switched back to 3.0.25 the icons came back.

    OK, so we’re talking about the social icons in the header… Installing the theme locally now to test this.

    Plugin Author Aristeides Stathopoulos

    (@aristath)

    I managed to add the social icons.
    With Kirki v3.0.25 they work fine and with v3.0.26 they don’t.
    The difference between v3.0.25 & 3.0.26 is that in the previous version there was a bug that was force-loading the fontawesome script regardless if you had a fontawesome control active or not.
    In v3.0.26 that bug was fixed (see issue https://github.com/aristath/kirki/issues/1786 and the commit that fixed it is https://github.com/aristath/kirki/commit/27a00a34e5e5358ce2d8596497af55a6ad38f2f8)

    Nothing gets removed from your theme, I can see that all assets you’re loading are fine and the browser gets them without any issues.

    The key to resolving this issue is the fact that Kirki is still using Font-Awesome v4.7.0.
    The script you’re bundling in your theme is for Font-Awesome v5.0.6.
    Perhaps the script was updated in the theme to 5+ but not the CSS for the icons?

    In TotalPress this line loads the script for font-awesome:
    wp_enqueue_script('fontawesome-all','get_template_directory_uri().'/assets/js/fontawesome-all.min.js'',array(),TOTALPRESS_VERSION,false);

    If I replace it with this, then it starts working again:
    wp_enqueue_script('fontawesome-all','https://use.fontawesome.com/30858dc40a.js',array(),TOTALPRESS_VERSION,false);
    In other words, removing the FA 5.0.6 script from your theme and replacing it with the FA 4.7.0 script resolves the issue.

    So perhaps the only reason it was working this whole time is because there was a bug in Kirki?

    You can try generating a link from their CDN on https://cdn.fontawesome.com/#request-embed-code and use that in your theme…

    Ok awesome.

    The foundation file in the theme has not been updated since it was approved by the review team.

    I don’t want to go to FA4 as this increases the size of the theme greatly.

    I may just remove it altogether and suggest a plugin for the icons.

    Thanks for taking the time to check, it means a lot.

    Keep doing what your doing cuz you have a great plugin here.

    • This reply was modified 3 weeks, 3 days ago by  ThemeAWESOME.
Viewing 8 replies - 1 through 8 (of 8 total)
  • You must be logged in to reply to this topic.