PHP 7.0 Compatibility

  • Resolved Texiwill

    (@texiwill)


    7 years, 8 months ago

    Hello,

    I ran the PHP Compatibility checker (New plugin) against the plugin and it has the following errors and warnings:

    FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/admin/wp-security-dashboard-menu.php
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
 644 | ERROR | INI directive 'safe_mode' is deprecated from PHP 5.3 and forbidden from PHP 5.4.
----------------------------------------------------------------------------------------------------------------------

FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/lib/whois/whois.ip.php
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 1 | WARNING | File has mixed line endings; this may cause incorrect results
--------------------------------------------------------------------------------------------------------

FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/lib/whois/whois.org.php
---------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 1 | WARNING | File has mixed line endings; this may cause incorrect results
---------------------------------------------------------------------------------------------------------

FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/lib/whois/whois.de.php
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 1 | WARNING | File has mixed line endings; this may cause incorrect results
--------------------------------------------------------------------------------------------------------

FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/lib/whois/whois.si.php
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 1 | WARNING | File has mixed line endings; this may cause incorrect results
--------------------------------------------------------------------------------------------------------

FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/lib/whois/whois.idna.php
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 918 | ERROR | Deprecated PHP4 style constructor are not supported since PHP7
----------------------------------------------------------------------------------------------------------

FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/lib/whois/whois.nz.php
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 1 | WARNING | File has mixed line endings; this may cause incorrect results
--------------------------------------------------------------------------------------------------------

FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/lib/whois/whois.client.php
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 546 | ERROR | Deprecated PHP4 style constructor are not supported since PHP7
------------------------------------------------------------------------------------------------------------

FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/lib/whois/whois.mobi.php
----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 1 | WARNING | File has mixed line endings; this may cause incorrect results
----------------------------------------------------------------------------------------------------------

FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/lib/whois/whois.ip.lib.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 1 | WARNING | File has mixed line endings; this may cause incorrect results
------------------------------------------------------------------------------------------------------------

FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/lib/whois/whois.parser.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 1 | WARNING | File has mixed line endings; this may cause incorrect results
------------------------------------------------------------------------------------------------------------

FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/lib/whois/whois.servers.php
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | File has mixed line endings; this may cause incorrect results
-------------------------------------------------------------------------------------------------------------

FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/lib/whois/whois.main.php
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------
   1 | WARNING | File has mixed line endings; this may cause incorrect results
 298 | ERROR   | Deprecated PHP4 style constructor are not supported since PHP7
----------------------------------------------------------------------------------------------------------

FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/lib/whois/whois.nl.php
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 1 | WARNING | File has mixed line endings; this may cause incorrect results
--------------------------------------------------------------------------------------------------------

FILE: /usr/share/wordpress/wp-content/plugins/all-in-one-wp-security-and-firewall/lib/whois/whois.utils.php
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 1 | WARNING | File has mixed line endings; this may cause incorrect results
-----------------------------------------------------------------------------------------------------------

    If they could be fixed.

    Thank you!
    Edward

    https://wordpress.org/plugins/all-in-one-wp-security-and-firewall/

Viewing 3 replies - 1 through 3 (of 3 total)
  • mra13

    (@mra13)

    7 years, 8 months ago

    There should be no issue with PHP7. Have you installed the plugin on a PHP7 site?

    Thread Starter Texiwill

    (@texiwill)

    7 years, 8 months ago

    Hello,

    Those are the errors that show up using the WPEngine “PHP Compatibility” plugin. While the plugin ‘may’ work in PHP 7, it would be best if there were no warnings or errors per such tools. They will be relied on when moving larger sites to PHP 7 and plugins will be dropped if they have such problems.

    At the moment, I am in compatibility test mode before migrating to PHP 7. Other plugins I use are in worse shape. :}

    I am more concerned about the Errors than warnings. When will PHP DROP deprecated constructors? The mixed line endings are not a huge issues.

    Best regards,
    Edward

    mra13

    (@mra13)

    7 years, 8 months ago

    We are totally going to make sure that there is NO warning at all. Thats the only thing we will accept.

    All of our plugin code (written by us) is PHP7 compatible. The only thing is that there are some features that require an external library. So if the code of that external library has issues then we have to kind of wait for that library to be updated by the respective developer.

    In your particular case, the warnings are coming from a library that we use for the “Whois Info” feature. Thats not really something that you have to worry about as you probably won’t be using that feature anyway.

    We will definitely be looking to upgrade that external library in our plugin as soon as we can find an updated version.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘PHP 7.0 Compatibility’ is closed to new replies.