[PR] Twitter button permalink doesn't work.

  • siroringo

    (@siroringo)


    7 years, 9 months ago

    So I will propose to change the following code.

    [juiz-social-post-sharer.php:234-236]

    // before

    case 'twitter' :
	                                                                $api_link = 'https://twitter.com/intent/tweet?source=webclient&original_referer=' . $url . '&text=' . $text . '&url=' . $url . $twitter_user;
                                                                break;

    // after

    case 'twitter' :
								$api_link = 'https://twitter.com/intent/tweet?' . 'text=' . $text . '&url=' . urlencode(get_permalink()) . $twitter_user;
								break;

    …I suggest to replace all $url change to urlencode (get_permalink ())

Viewing 1 replies (of 1 total)
  • Plugin Author Geoffrey

    (@creativejuiz)

    7 years, 9 months ago

    Hello,

    This link actually works fine.
    $url is already encoded, so I don’t understand what your are suggested.

    Please read the code below these lines and try to find occurrences of $url to understand the work done on it.

    Thank you.
    Tell me if you have question, or if you can be more explicit than “doesn’t work”.

Viewing 1 replies (of 1 total)
  • The topic ‘[PR] Twitter button permalink doesn't work.’ is closed to new replies.