Custom logo issue in Customizer

Guido
(@guido07111975)

8 years ago
Hi,

I’m including the new logo feature in my themes but run into a minor issue.

Functions.php:
```
add_theme_support( 'custom-logo' );

function my_logo() {
	if ( function_exists( 'the_custom_logo' ) ) {
		the_custom_logo();
	}
}
```
Header.php:
```
<?php if ( has_custom_logo() ) : ?>
	<?php my_logo(); ?>
<?php else : ?>
	<h1><a href="<?php echo esc_url( home_url( '/' ) ); ?>" title="<?php bloginfo('name'); ?>"><?php bloginfo('name'); ?></a></h1>
	<h2><?php bloginfo('description'); ?></h2>
<?php endif; ?>
```
Does work fine in frontend: in case no logo is set the title and tagline is displayed.

But, in backend (customizer) I have an issue when removing the logo: the title and description won’t display in customizer.
But when I close and re-visit the customizer the title and description is displayed again.

So I’m wondering of my header code the right way to display logo?

Guido

Viewing 4 replies - 1 through 4 (of 4 total)

Thread Starter Guido
(@guido07111975)

7 years, 7 months ago
Hi,

Did a new test with most recent WP version and issue is still te same:

I go to the Site Identity section (pic 1)
I set a new logo (pic 2) and press save (logo is set)
Then I remove it again and site title and tagline are gone (pic 3)

In frontend no issue, only in customizer.

Any thoughts? Something wrong with my code?

Guido
- This reply was modified 7 years, 7 months ago by Guido.
Moderator bcworkz
(@bcworkz)

7 years, 7 months ago

Hi Guido,

I’m not very knowledgeable about how the customizer works, but I think the behavior you’re seeing is because the logo and title/tagline are in the same container, combined with the only-show-if-no-logo logic. I’m guessing the Customizer is not actually reloading the page in this instance, rather it’s taking a shortcut and hiding the logo container, assuming the title/tagline is elsewhere. This reflects the typical twenty* model theme approach where the visibility of each is managed separately.

You could try putting the elements in separate containers, the visibility of each still managed with if (or not) has_custom_logo(). Or use the model theme approach where each element is managed individually regardless of the state of the other.

If the current logic is important to your theme’s concept, you probably need to manage the visibility of the elements through the Customizer’s postMessage facility.

FYI, because of how the forums sort topics since the bbPress upgrade, (by original post date instead of last reply like before) it’s only through crazy luck where anyone would see your new post updating a 5 month old original topic. While we’re not supposed to duplicate topics, I would hope you would be forgiven if you started a new topic related to a very old one. It’s the only way you could reasonably expect others to see your post.

The only reason I saw your post was I was using RSS to see if I had missed any replies, since subscribing to topics doesn’t work well for me. It’s still a flawed approach because we can’t get older feed pages.
Thread Starter Guido
(@guido07111975)

7 years, 7 months ago
Hi BC,

Luckely you did came across it. Strange decision to list topics like this.

New themes should set a logo as listed above, but the way my logo is integrated in my header file I’m not gonna do this like above (yet). Indeed, Twenty Sixteen sets a logo in addition to the site title and tagline, that’s the difference.

I now use the Customizer API and I think I’m gonna leave it this way for now 😉

Have a nice evening!

Guido
- This reply was modified 7 years, 7 months ago by Guido.
Moderator bcworkz
(@bcworkz)

7 years, 7 months ago

FWIW, the forum sort order wasn’t really a decision, more like the bbPress migration forced it. Queries to list topics by last reply in this extremely large DB was killing the servers, sorting by topic date was the only way to keep things running during the transition. Everyone involved is aware that the situation is far from optimal, but there’s higher priority issues to deal with first. It’s not clear what the solution will be, but the current state is not workable in the long run.

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Custom logo issue in Customizer’ is closed to new replies.

Custom logo issue in Customizer

Tags

Topics

Topics with no replies

Non-support topics

Resolved topics

Unresolved topics

All topics