Support » Plugins » [Plugin: Openid] Name and trailing slash issue

  • Hi there. I’m insanely thankful for the OpenID plug-in, it’s extremely useful and it works as advertised, with one small exception.
    When a comment is added using OpenID, the name of the commenter is displayed as his OpenID URL with a trailing slash.
    Like this: someone.livejournal.com/
    Or this: someone.blogspot.com/

    I’ve read OpenID specifications, and I know OpenID can provide additional information (including real name), so is it possible to show this (like, Some One instead of someone.livejournal.com/), or at least get rid of the trailing slash?

    Thank you!

    http://wordpress.org/extend/plugins/openid/

Viewing 7 replies - 1 through 7 (of 7 total)
  • OpenID 3.2.2 on WP 2.7.1 – same problem.

    also, doesn’t fill out E-mail field at all 🙁

    Yeah, I would guess this only happens when we have the

    Don’t require name and e-mail for comments left with verified OpenIDs

    option set.

    From what I can tell, the plugin is verifying the openID delegate, but afterwards it only duplicates the name of the URL listed as the “name”. It does not look in the sreg in OpenID in order to retrieve the nickname or e-mail values.

    if you look at the plugin under the comments.php file, lines 111-118 appear to show an intent to obtain this data later on. Lines 295-304 look like some attempt to obtain user data, but I can’t tell if it’s trying to interface with sreg. Finally, down at lines 354-378, looks like this is where it is trying to record what it obtained back in lines 295-304, so maybe the problem is in 295-304?

    Perhaps it needs some tweaking? I did find some info on interfacing with sreg here:

    http://wiki.diso-project.org/wordpress-openid-api#ExtendingtheOpenIDnbspProviderSimplenbspRegistration

    please feel free to let me know if i don’t know what i’m talking about. : )

    ok, I have tested and confirmed that this only happens when the “Don’t require name and e-mail for comments left with verified OpenIDs” option is set. If that option is left unchecked (off), then wordpress will not allow a user to leave a comment with openID unless Name and e-mail are explicitly provided, in which case it will pull those values into the comment data.

    It would appear that lines 354-377 of openid/comments.php is attempting to pull the data from sreg:

    /**
    * Retrieve user data from comment form.
    *
    * @param string $identity_url OpenID to get user data about
    * @param reference $data reference to user data array
    * @see get_user_data
    */
    function openid_get_user_data_form($data, $identity_url) {
    $comment = $_SESSION[‘openid_comment_post’];

    if (!$comment) {
    return $data;
    }

    if ($comment[’email’]) {
    $data[‘user_email’] = $comment[’email’];
    }

    if ($comment[‘author’]) {
    $data[‘nickname’] = $comment[‘author’];
    $data[‘user_nicename’] = $comment[‘author’];
    $data[‘display_name’] = $comment[‘author’];
    }

    return $data;
    }

    where it’s asking for nickname and user_e-mail, it should be importing the values from that array straight into the comments. for some reason, it is not. i’m not educated enough in wordpress or php to know why, though.

    one possible issue, and I’ll still have to test this, is that we’re all using phpMyID to host our own openIDs? If so, it may be that phpMyID is still conforming to an older OpenID spec and that this is relying on 2.0.

    scratch that, it’s not phpMyID… gave it another shot with a different openID login and experienced the same results.

    ok, I’ve done some regression testing and found that the sreg values are being imported properly at least as far back as version 3.1.4 for this plugin. Looking at the readme, the changelog for 3.2 was substantial. one of the listings was:

    “- don’t return empty SREG values”

    Therefore, I’m guessing something in that change caused this.

    Unfortunately, there may be other issues with 3.1.4. For instance, in safari, it will go to the openid provider, but won’t come back to the blog to finalize the comment. it does seem to work in firefox. haven’t tested other browsers.

    anyway, hope this helps. if you’re having this problem, you may either wish to wait until the next update, or regress 3.1.4 and try your luck.

    Confirmed that SREG values are imported improperly (not at all) starting in version 3.2.

    At this point I am stumped. I suggest comparing version 3.1.4 and 3.2 to see where the offending change occurred.

    Best of luck.

    i have the same problem too with 3.2.2
    i registered the issue on the project’s bug tracker
    http://code.google.com/p/diso/issues/detail?id=129

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘[Plugin: Openid] Name and trailing slash issue’ is closed to new replies.