[wpv-conditional] causes out-of-memory error, 500 error for certain fields

Hello,

After much debugging we’ve found the root of an intermittent problem where our pages were blank and returning 500 errors. It appears that [wpv-conditional] has some serious problems if the field content it is comparing contains a single quote. Since single quotes are used to build the parser expression, this causes an infinite loop (probably because it cannot find the ending quote).

To replicate:

• Create a new custom post type
• Create a custom field that permits multiple instances
• Add a post of that type, and add at least 1 value that contains a single quote in that field
• Create a new view
• Add a wpv-conditional statement (the statement being evaluated isn’t important as long as it references the field)
• Render the view and observe 500 errors/out-of-memory

See: embedded/common/expression-parser/parser.php function Tokanize

I’ve reproduced this on multiple servers and versions of PHP. For now we’re going to have to HTML-encode our single quotes before they get entered into Types!

Best,
Aaron

https://wordpress.org/plugins/types/