dcl-functions.php line 89 throws an error

  • Resolved HackYaaaaa

    (@hackyaaaaa)


    8 years, 7 months ago

    because your script runs before my jQuery is loaded.

    In order to create a theme that scores 98~100 (depending on the server setup) on google pagespeed test, I had to defer load all of my js.

    So thus the error.

    Official Disqus plugin works fine but the official plugin lowers the google pagespeed score down to 94~96 range on my theme.

    I can defer load Disqus manually without your plugin but I won’t by able to sync Disqus comments with WordPress if I did that.

    Since the portion of the script which throws the error is inside your php script, there isn’t anyway for me to defer that part of js. At least I can’t figure out how I can do that without ripping your plugin apart & porting what I need.

    I think this is by far the best Disqus plugin available. Would you be willing to rewrite your plugin so that defer loading of js can be possible?

    Thanks a bunch. Your plugin is simply the best!!

    https://wordpress.org/plugins/disqus-conditional-load/

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Joel James

    (@joelcj91)

    8 years, 7 months ago

    Hey HackYaaaaa,

    Thanks for the feedback and suggestion!

    The good news is that I have noticed this issue a few days before and I am currently working on it :). Soon I will be releasing a solution for that. I will update you once I release the fix.

    Thread Starter HackYaaaaa

    (@hackyaaaaa)

    8 years, 7 months ago

    That’s super awesome to hear!!!

    I actually solved the problem by moving the js portion of dcl-functions.php outside of the php & creating a separate js file. LOL

    But obviously, that’s not an universal nor a proper solution for the plugin.

    I really look forward to your solution so that I can learn (I am a self-taught hacker, not a programmer) from your code.

    Disqus is by far one the biggest pageload performance culprits & I am surprised your plugin is not more popular or widely used.

    I will be promoting your plugin to anyone who are using/intending to use Disqus.

    Plugin Author Joel James

    (@joelcj91)

    8 years, 4 months ago

    Hello? Did you try updating to latest version? Now we don’t need jQuery at all!

    Thread Starter HackYaaaaa

    (@hackyaaaaa)

    8 years, 1 month ago

    Hey!! You da man!!!

    You rock.

    I’ve been busy with a project for past couple of months.

    Just downloaded your plugin to study how you’ve done it.

    Your plugin is super clean.

    It’s so weird. The script I hacked together to load js on scroll is very similar to how you did it in your plugin.

    if(document.body.scrollHeight < window.innerHeight){ (your code)

    if ($(this).scrollTop() + $(window).height() > scrollFromTop){ (my hack)

    hahaha

    Anyhow Congragts!!!

    I will promote your plguin to everybody I know as your plugin is just awesome.

    Plugin Author Joel James

    (@joelcj91)

    8 years ago

    Thank you so much 🙂

    Plugin Author Joel James

    (@joelcj91)

    8 years ago

    Thank you so much 🙂

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘dcl-functions.php line 89 throws an error’ is closed to new replies.