og:image problem

understood the issue… you stop at the very first image and check if has the correct size. If not, you use the default image (if set by the user) Wrong. (’cause may be more images, sometimes the first image may be not so big, could be a little logo or such like that, could be a hidden image to display, a hidden image by jQuery… could be many things..)

EVEN IF the user chooses one image only, (“Max Images to Include”), You have to do a cycle until you find an image with the size greater than that set by the user.

eg. the user wants one image only and sets a 200×200 size (the minimum accepted on Facebook). You do an array searching for the images contained into the post until you find an image greater (or equal) than 200×200.

THEN, and only then, if the good image is not found, you insert the default image and so on…

hope this helps

another issue,
even if I set 2 images…

the image at the bottom is not taken anyhow…
so it’s definitely a bug

How you get the width/height of the image?
If you search for the tags width height in html is wrong, you have to code in php something like getimagesize(“$url”); and then you have width in $size[0] and height in $size [1]

public function get_size_info( $size_name = 'thumbnail' ) {
if ( is_integer( $size_name ) )
return;
if ( is_array( $size_name ) )
return;
global $_wp_additional_image_sizes;
if ( isset( $_wp_additional_image_sizes[$size_name]['width'] ) )
$width = intval( $_wp_additional_image_sizes[$size_name]['width'] );
else $width = get_option( $size_name.'_size_w' );
if ( isset( $_wp_additional_image_sizes[$size_name]['height'] ) )
$height = intval( $_wp_additional_image_sizes[$size_name]['height'] );
else $height = get_option( $size_name.'_size_h' );

if ( isset( $_wp_additional_image_sizes[$size_name]['crop'] ) )
$crop = $_wp_additional_image_sizes[$size_name]['crop'];
else $crop = get_option( $size_name.'_crop' );
if ( ! is_array( $crop ) )
$crop = empty( $crop ) ? false : true;
return array( 'width' => $width, 'height' => $height, 'crop' => $crop );
		}

and

// try and get the width and height from the image attributes
							if ( ! empty( $og_image['og:image'] ) ) {
								if ( preg_match( '/ width=[\'"]?([0-9]+)[\'"]?/i', $tag_value, $match) )
									$og_image['og:image:width'] = $match[1];
								if ( preg_match( '/ height=[\'"]?([0-9]+)[\'"]?/i', $tag_value, $match) )
									$og_image['og:image:height'] = $match[1];
							}

this is unneeded stuff, really… recheck your code and simplify, this is my suggestion. The plugin, as it is now, fails with external images for sure…then i didn’t test deeply, maybe it works fine when you don’t use the preg_match…but the preg_match part must be reviewed… bye

pardon, thanks for your comments…
it’s easier than you can think… already explained.

it’s enough to take the image size by getimagesize();

it’s pointless in the other way, ’cause on the post there may be external images without width/height tags and you can’t force users to always write width= and height= . If not, you ignore the images? No, THIS is wrong 😉

with getimagesize() you bypass any issue easily with a few lines of code.
the only issue COULD be a temporary connection problem, but that may be tolerated ’cause is really sporadic. Even in that case (and, if more images on the post content) you can always do a cycle to get the found and correct image in the cycle. The problem is if you steadily ignore the img without width height tags, instead.
thanks

this is a temporary workaround on lib/media.php

// try and get the width and height from the image attributes
if ( ! empty( $og_image['og:image'] ) ) {
//if ( preg_match( '/ width=[\'"]?([0-9]+)[\'"]?/i', $tag_value, $match) )
$size = getimagesize("$attr_value");
$og_image['og:image:width'] = $size[0];
//if ( preg_match( '/ height=[\'"]?([0-9]+)[\'"]?/i', $tag_value, $match) )
$og_image['og:image:height'] = $size[1];
}