• Resolved gfields108

    (@gfields108)


    I am getting this recommendation from Theme Check even though my searchform.php uses the same code from the Codex for the HTML 5 searchform:

    RECOMMENDED: Text domain problems in searchform.php. You have not included a text domain!
    
    Line 3: <span class='screen-reader-text'><?php echo _x( 'Search for:', 'label' ) ?></span>
    
    Line 4: <input type='search' class='search-field' placeholder='<?php echo esc_attr_x( '', 'placeholder' ) ?>' value='<?php echo get_search_query() ?>' name='s' title='<?php echo esc_attr_x( 'Search for:', 'label' ) ?>' />

    The searchform.php code:

    <form role="search" method="get" class="search-form" action="<?php echo home_url( '/' ); ?>">
    	<label>
    		<span class="screen-reader-text"><?php echo _x( 'Search for:', 'label' ) ?></span>
    		<input type="search" class="search-field" placeholder="<?php echo esc_attr_x( '', 'placeholder' ) ?>" value="<?php echo get_search_query() ?>" name="s" title="<?php echo esc_attr_x( 'Search for:', 'label' ) ?>" />
    	</label>
    	<input type="submit" class="search-submit" value="<?php echo esc_attr_x( 'Search', 'submit button' ) ?>" />
    </form>

    Am I doing something wrong?

    https://wordpress.org/plugins/theme-check/

Viewing 1 replies (of 1 total)
  • There are missing domains here:

    (1)<?php echo _x( ‘Search for:’, ‘label’ ) ?>
    (2) placeholder=”<?php echo esc_attr_x( ”, ‘placeholder’ ) ?>
    (3) esc_attr_x( ‘Search’, ‘submit button’ )

    ==> You should include text-domain there

    (1) <?php echo _x( ‘Search for:’, ‘label’ , ‘text-domain’) ?>
    (2) placeholder=”<?php echo esc_attr_x( ”, ‘placeholder’ , ‘text-domain’) ?>
    (3) esc_attr_x( ‘Search’, ‘submit button’ , ‘text-domain’ )

Viewing 1 replies (of 1 total)
  • The topic ‘Text domain problems on default HTML 5 searchform code’ is closed to new replies.