bug, clashes with other pugins !

  • Resolved wtfusdfdsfsdgkdkjldlgkljdfkj

    (@wtfusdfdsfsdgkdkjldlgkljdfkj)


    9 years ago

    In the file maxgalleria.php at line 623 you have a function group_attachments
    which is one of the most irresponsible functions i’ve seen for many a year.
    Have just spent 3 hours debugging why the media grid function hangs.

    Have finally found out the reason, if any other plug in, is using a groupby clause in there sql, your function will break it.
    Because you dont check !!!!!!!!!!!!!!!!
    So you get a sql query with
    GROUP BY wp_posts.ID guid

    which surprise, surprise DOES NOT WORK !
    In this case, was clashing with the “Enhanced Media Library” plugin

    If you are going to add / change base functionality, it would help if you remember that you are not the only plugin in the world.
    Have now changed this to
    public function group_attachments($groupby) {
    if ($groupby != ”) {
    $groupby .= ” , guid”;
    } else {
    $groupby .= ” guid”;
    }
    return $groupby;
    }
    Will see if this works

    https://wordpress.org/plugins/maxgalleria/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author AlanP57

    (@alanp57)

    9 years ago

    Thanks wtfusdfdsfsdgkdkjldlgkljdfkj!

    You know it is really hard to find anything about how to make use of the posts_groupby filter. If we would have know about about the different things we could do to make the filter safer we would have certainly done them from the start. And neither did we know about the Enhanced Media Library at the time we first added the group by filter but we have been in contact with the plugin author once the problem first showed up. Now your advice resolves this conflict and we are very grateful.

    We will be releasing a new version of Maxgalleria today.

    If this solves your issue thanks in advance for marking this thread as ‘Resolved’ so we know your question has been answered and for giving us and our plugin a rating at Maxgalleria Reviews

    Alan

    Thread Starter wtfusdfdsfsdgkdkjldlgkljdfkj

    (@wtfusdfdsfsdgkdkjldlgkljdfkj)

    9 years ago

    ok thanks, glad its fixed

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘bug, clashes with other pugins !’ is closed to new replies.