Incompatible with Slider Pro

Hi there,

Thanks for the free plugin and the hard work that you put in to it. As a plugin developer myself, I can appreciate giving away work for free to help others out.

I am developing a site for a client, and they’ve chosen to use your gallery plugin. It appears that your plugin is causing some issues.

First, you load a JS file (gallery-all.js) on every page on the front end, regardless of if your gallery is being displayed. This may be considered bad practice. I’m noticing this because it’s being enqueued on a page where we have a slider generated by Slider Pro.

A few seconds after a slide appears it slides upwards, out of the view of the slider.

After some digging around in your source files, I see that inside of gallery-all.js you have a function called doMove() which checks on the location of your slider image and makes all the animations happen.

The class name that you’re using to target the slider is very generic :

if (movement == tooFar) {
   jQuery(".slide img").animate({
     "top": -200
}, etc.

You can see the element it’s targeting is .slide img, which is the same as a the Slider Pro class names.

I’m wondering if you would consider adding something a little more specific to your plugin to target, say .hugeIT .slide .img or something similar.

For now we’ve had to hack up your plugins code to prevent this file from being loaded at all.

I would also recommend you put this code up on GitHub to allow for pull requests to be made, so other users can openly help develop the plugin further.

Thanks again for all your hard work.

Evan

https://wordpress.org/plugins/gallery-images/