[Plugin: ICS Calendar] Minor Bug: All Day Events on Dec 31

  • randyhoyt

    (@randyhoyt)


    15 years, 4 months ago

    All-day events on December 31 do not get treated as all-day events. I’m using an ICS file created by Google Calendar. In version 1.2.4, the problem seems to be in ics-functions.php, line 595:

    593 return (abs($gmt2 - $gmt1) == 86400
    594 and $local1['tm_hour'] == 0
    595 and $local1['tm_year'] != $local2['tm_year']);

    This is checking to see that the year of the start date and the year of the end date are the same … which, in an all-day event from December 31 12:00 AM – January 1 12:00 AM, they are not. I took out line 595 (except for the semi-colon) and it seems to work fine. Is there a reason the check for the year is in there?

    Thanks,
    ~randy

    http://wordpress.org/extend/plugins/wordpress-ics-importer/

Viewing 1 replies (of 1 total)
  • dolfelt

    (@dolfelt)

    15 years, 4 months ago

    You know, I am not sure why I check the year. I will look into this more and include a fix for it in the next release. I am just worried that removing the year check will have other repercussions.

    Daniel

Viewing 1 replies (of 1 total)
  • The topic ‘[Plugin: ICS Calendar] Minor Bug: All Day Events on Dec 31’ is closed to new replies.