Issues in custom_list_forums

  • Resolved mordisko

    (@mordisko)


    9 years, 2 months ago

    Hey there.

    I love this plugin and this will be the first time that I activelly register to rate something and give some feedback to the support page. Congrats on your work, seriously, it saved me a lot of time.

    Well, the thing is that the function custom_list_forums (forum-filters.php) seems to be doing two things which I think are not entirely correct.

    First of all, it will always create a “bbp-forum-content” div even if the content of a forum is empty. This seems not a big deal, but this may break your CSS if you are not using the content feature at all.

    Secondly, its appending and preppending $r[“before”] and $[“after”] to each “bbp-forum-link”. I’m pretty sure that this is not the expected behaviour. According to this it should be sent before and after all the returned data.

    Overall I managed to modify the file to our needs and everything is OK but I just wanted to let you know so that you have that in your consideration.

    Cheers!,
    Héctor

    https://wordpress.org/plugins/bbp-private-groups/

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Robin W

    (@robin-w)

    9 years, 2 months ago

    Hector,

    Thanks for the great feedback.

    The vast majority of improvements to this plugin come from people such as yourself who have either founds bugs, inconsistencies or have suggestions for future releases, and the plugin would not continue to get better without you, so I really appreciate all feedback.

    I’ll take a look at this code, it sounds like it could be better !

    Could I be cheeky and ask you to let me have a copy of the revised custom_list_forums function you changed, as this will save me duplicating your work.

    You can either post it as a response to this post, or contact me via my website

    http://www.rewweb.co.uk/contact-me/

    Thanks again, and please do come back with anything else you think will improve the plugin

    Regards

    Robin

    Thread Starter mordisko

    (@mordisko)

    9 years, 2 months ago

    Of course I can. There you go: pastebin.

    That’s a custom filter that I replaced on my site and currently is working fine.

    I don’t remember coding anything site-specific in there, but I could be wrong.

    Regards.
    Héctor

    Plugin Author Robin W

    (@robin-w)

    9 years, 2 months ago

    Hey thanks for posting that – I’ll look to incorporate it into the next version

    Regards and thanks again

    Robin

    Plugin Author Robin W

    (@robin-w)

    9 years, 1 month ago

    Now incorporated into version 2.5.5

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Issues in custom_list_forums’ is closed to new replies.