Version links with spaces lead to download version 1

Resolved inspirationally
(@inspirationally)

9 years, 2 months ago

I have just added nearly 100 downloads to our 2015 category and worked with versions. But then I (well a visitor) realized, that all other versions all lead to version number one.
I switched to default templates (page addon), but they don’t work, too.

Here a link: http://johnny-depp.org/media/downloads/download-info/mortdecai-premiere-la-january-21-2015/

I JUST REALIZED THIS IS FOR VERSIONS WITH EMPTY SPACES ONLY!!

if you click “previous versions”, for example the first “other version” is
http://johnny-depp.org/media/downloads/download/mortdecai-premiere-la-january-21-2015/?version=redcarpetfootage#2

but if you click that link, it still downloads the reuters video.

although in the admin panel, it leads to http://media.johnny-depp.org/dlm_uploads/2015/20150121_mortdecai_prem_LA_red_carpet_footage_2.mp4

Any idea how to solve this?

I already tried switching to ID instead of slug and reloaded permalinks. And removed the cache plugin.

https://wordpress.org/plugins/download-monitor/

Viewing 6 replies - 1 through 6 (of 6 total)

Thread Starter inspirationally
(@inspirationally)

9 years, 2 months ago

I had to rename them all to with hyphens, but it is not that I like reading-titles-like-this-all-the-time. I also readded my own templates and the cache plugin, but that was not the reason. You can now see here:
http://johnny-depp.org/media/downloads/download-category/2015/ under
“Mortdecai Premiere London, January 19, 2015” – the last one – “test file with empty space” for testing. It should download fox5dc.mp4 but downloads the first one of the day.

Plugin Contributor Barry Kooij
(@barrykooij)

9 years, 2 months ago

I’m not sure I understand. The last file under “Mortdecai Premiere London, January 19, 2015” is working fine for me. What exactly is the problem? If you enter spaces in a file version?

Thread Starter inspirationally
(@inspirationally)

9 years, 2 months ago

Hey, thanks for your answer –

yes – if the file version has spaces, it downloads the first version.

See under “download part test file with empty space” on the linked site = the last one from January 19 (the bottom one)

It SHOULD download “20150120_mortdecai_pressjunket_london_fox5dc.mp4”
but it DOES download “20150120_mortdecai_pressjunket_london_theatreunderthestars.mp4” which is the first version.

Plugin Contributor Barry Kooij
(@barrykooij)

9 years, 2 months ago

Alright. You are correct, the file version (like 1.0.1) should not have spaces. I will make sure next version disallows spaces in the field.

I’ve created a GitHub issue where you can follow further development: https://github.com/download-monitor/download-monitor/issues/233

Thanks for reporting.

Thread Starter inspirationally
(@inspirationally)

9 years, 2 months ago

Thank you! Any possibility to do it vice versa? To make spaces working/possible instead of disallowing them? I know, it is for file version like 1 or 2 or 1.0.1, but people may also use 12 a or sunday 1 or January 31…or like I do with full name. With empty spaces.

Plugin Contributor Barry Kooij
(@barrykooij)

9 years, 1 month ago

Fixed this by sanitizing titles on download request so spaces in titles are still allowed. This fix will be included in version 1.7.0

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘Version links with spaces lead to download version 1’ is closed to new replies.