4.0 RC 1: Plugin Info Modal Close Button Does Not Announce for Screen Readers

  • Resolved David A. Kennedy

    (@davidakennedy)


    9 years, 7 months ago

    The plugin info modal close button does not announce for screen readers.

    This is the link with an id of TB_closeWindowButton.

    • The link uses only icon fonts inside the , but icon fonts are not announced by screen readers.
    • The title attribute may be intended for screen readers, but it’s not announced by default by screen readers either, and it’s really only useful for users with a mouse. See this post for more info on the title attribute.
    • When a screen reader announces these links, it says: “Link”, which isn’t descriptive and doesn’t tell the user what the link does or where it goes.

    Suggested fix:

    The text “Close” can be added with a class of screen-reader-text.

    • Links should always have link text.
    • The screen-reader-text would be hidden off-screen, maintaining the design of the close link.

    This would have it announce in screen readers. And be an easy fix. 🙂

Viewing 4 replies - 1 through 4 (of 4 total)
  • Moderator Dominik Schilling

    (@ocean90)

    WordPress Core Developer

    9 years, 7 months ago

    Is there a reason why you haven’t created a ticket directly? And I’m sure you can.

    Thread Starter David A. Kennedy

    (@davidakennedy)

    9 years, 7 months ago

    Done! https://core.trac.wordpress.org/ticket/29455

    Sorry about that, I wasn’t thinking and thought this is where you all wanted everything at this point.

    Moderator Ipstenu (Mika Epstein)

    (@ipstenu)

    🏳️‍🌈 Advisor and Activist

    9 years, 7 months ago

    We do 🙂 Sometimes people aren’t sure if something SHOULD be in trac or not. It’s hard to tell at times. So thank you for posting here and for making a ticket! We love that 😀

    We mark posts that have trac tickets as resolved for sanity. It lets mods and volunteers know we don’t have to jump in and find an issue. You should follow the discussion on trac. You can click the ‘Watch’ button on the trac ticket (it’s near the bottom) to get email alerts. If you need to log in, it’s the same ID/password as you use for the forums.

    Thread Starter David A. Kennedy

    (@davidakennedy)

    9 years, 7 months ago

    Thanks, Mika! That’s super helpful to know.

    Most of the testing and Trac-ing I’ve done in the past has been before the release candidate phase, so I wasn’t sure of the preferred workflow. 🙂

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘4.0 RC 1: Plugin Info Modal Close Button Does Not Announce for Screen Readers’ is closed to new replies.