The auto coupon shows up for sale items

Jeasy,

There seems to be a problem in the existing WooCommerce coupon class. The problem also exists if the coupon isn’t marked as an ‘Auto Coupon’.

I’d suggest you’d contact Woothemes about the issue, because it seems to be a bug.

I made a quick fix. As a workaround paste the following code in your functions.php, tested in WooCommerce 2.1.12:


add_filter('woocommerce_coupon_is_valid', 'woocommerce_coupon_is_valid', 10, 2 );

function woocommerce_coupon_is_valid( $valid, $coupon) {
if ( $valid && $coupon->exclude_sale_items == 'yes' ) {
$product_ids_on_sale = wc_get_product_ids_on_sale();
if ( sizeof( WC()->cart->get_cart() ) > 0 ) {
foreach( WC()->cart->get_cart() as $cart_item_key => $cart_item ) {
if ( in_array( $cart_item['product_id'], $product_ids_on_sale, false ) || in_array( $cart_item['variation_id'], $product_ids_on_sale, false ) || in_array( $cart_item['data']->get_parent(), $product_ids_on_sale, false ) ) {
return false;
}
}
}
}
return $valid;
}

Let me know if this solves your problem.

Please don’t forget to rate my plugin!

Jos.

The coupon class has some more errors. If I change the woocommerce_coupon_is_valid to your needs, the discount will be applied to all products, (also to sale products). More functions in the coupon class have to be overridden to let it work the way it should.

Let me know if the Woo guys come up with a fix, if not you’ll need another workaround, but the functionality might break in future WooCommerce releases.