Support » Theme: Customizr » Moving subfolder PARTS under INC in version 3.1.17, not good for child-themes

  • Resolved Giorgio25b

    (@giorgio25b)


    Hi awesome dev team!
    It took me a bit to figure out what went wrong after updating to 3.1.17.

    You moved the sub-folder PARTS under INC. I’m sure you had very good reasons, but in some of my child themes I have the folder PARTS where I override header and footer.

    OK it easily solvable adding an INC folder in my child-theme directory and moving PARTS within it… but:

    what is absolutely weird is that the footer files are not affected by the presence or less of the top folder INC; so far only the class-header-header_main.php is affected by this.

    Thanks,
    Giorgio

Viewing 11 replies - 1 through 11 (of 11 total)
  • Theme Author presscustomizr

    (@nikeo)

    Hi @giorgio25b,

    In the future theme updates, the stucture will not change anymore :)!

    The next release will allow you to easily overrive any classes thanks to a conditional statement : if ( class_exists(…) ) { class … {} }. In other words, core classes are made “pluggable”.
    I hope this will make it more convenient for you to work with child theme.

    That says however, I would be interested to know why you prefer overriden the core classes instead of using the theme’s hooks API (filters and actions) :
    – Are there any hooks missing that you would like to see in the theme ?
    – Can you provide an example of the type of features / functions you override in your child themes?

    Thanks and I look forward to reading from you!

    Thread Starter Giorgio25b

    (@giorgio25b)

    Thanks Nicholas,

    I’m looking forward to the new version!

    The reason why I did not use the hooks is because at the beginning I was too lazy or in a rush to write my own filters for all the customizations needed.
    I’m not overriding the code in that brutal way anymore and here I promise to use only custom filters and actions like this one:

    //function to override the menu wrapper's class
    
    function my_custom_navbar_wrapper_class() {
    	echo apply_filters( 'my_custom_navbar_wrapper_class', 'navbar-wrapper clearfix span12' );
    }
    add_filter('tc_navbar_wrapper_class', 'my_custom_navbar_wrapper_class' );

    Thanks,
    Giorgio

    Theme Author presscustomizr

    (@nikeo)

    OK thanks for this feedback Giorgio. 😀

    That’s indeed the best way to use the theme!

    Keep up the good work on your websites!

    Thread Starter Giorgio25b

    (@giorgio25b)

    oh btw,
    here is where I needed the menu wrapper to be span12:
    http://www.fipa.bc.ca/

    Thanks and 2 ∞ & →

    Theme Author presscustomizr

    (@nikeo)

    So nicely designed!

    Thread Starter Giorgio25b

    (@giorgio25b)

    Thanks,
    I did the theme development and Customizr rocks for this, the visual design has been done by WorkingDesign.net

    To the next then.
    G.

    Theme Author presscustomizr

    (@nikeo)

    You are doing awesome => keep submitting you best creations to the Customizr theme showcase!

    I’m having the same/similar issue with one of two Customizr child-themes on a WP multisite server.
    The problematic child-theme delivers no Customizr CSS because the link is wrong: ‘…/wp-content/themes/customizr/inc/css/red.min.css’.
    In the other child-theme it is correct: ‘../wp-content/themes/customizr/inc/assets/css/green.min.css’
    Debug steps:
    1) The child-theme blog.php and functions.php are extactly the same in both versions
    2) I did delete the WP Super Cache
    3) I’m now trying to compare and find if style.css can cause this, but so far could not find anything

    @chrisfo, please start a new thread.

    done 🙂

    Thread Starter Giorgio25b

    (@giorgio25b)

    code correction here below:

    //function to override the menu wrapper's class
    
    function my_custom_navbar_wrapper_class() {
    	return apply_filters( 'my_custom_navbar_wrapper_class', 'navbar-wrapper clearfix span12' );
    }
    add_filter('tc_navbar_wrapper_class', 'my_custom_navbar_wrapper_class' );

    changed echo with return

Viewing 11 replies - 1 through 11 (of 11 total)
  • The topic ‘Moving subfolder PARTS under INC in version 3.1.17, not good for child-themes’ is closed to new replies.