BUG in notifyPost si_captcha_register_form()

Hey!

Going through your code you use si_captcha_register_form both for registration and lost password forms…

hook here add_action(‘register_form’, array(&$si_image_captcha, ‘si_captcha_register_form’), 10);

and here add_action(‘lostpassword_form’, array( &$si_image_captcha, ‘si_captcha_register_form’), 10);

Issue is that the function si_captcha_register_form() returns true if the option for registration is turned off but the option for lost password is on which result in not captcha displayed in the lost password form and then when you submit obvisouly you get an error stating the captcha is missing…

function si_captcha_register_form() {
   global $si_captcha_url, $si_captcha_opt;

   if ($si_captcha_opt['si_captcha_register'] != 'true') {
        return true; // captcha setting is disabled for registration
   }

should be

function si_captcha_register_form() {
   global $si_captcha_url, $si_captcha_opt;

   if (($si_captcha_opt['si_captcha_register'] != 'true')&&($si_captcha_opt['si_captcha_lostpwd'] != 'true')) {
        return true; // captcha setting is disabled for registration
   }

Cheers

https://wordpress.org/plugins/si-captcha-for-wordpress/