wp-Typography Plugin causes issue with NextGen Gallery 2.0.14

  • stmblhappiness

    (@stmblhappiness)


    10 years, 8 months ago

    I’ve just updated to the newest version of NextGen Gallery (2.0.14) and all of my singlepic shortcodes stopped working. I reinstalled NextGen Gallery and still had the issue so I deactivated all of my other plugins and went through one by one to re-activate them. I discovered that the wp-Typography plugin (version 2.0.4) was the culprit. I’d really like to be able to use both plugins together, but for the moment I have the wp-Typography plugin disabled so that my photos are still visible.

    http://wordpress.org/plugins/nextgen-gallery/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Contributor photocrati

    (@photocrati)

    10 years, 8 months ago

    @stmblhappiness – Thank you for posting this information! We appreciate how much of an inconvenience it can be troubleshooting plugins. I’ve made a quick note of this issue, but if you would like to file a Bug Report on this as well it would also be greatly appreciated.

    Here is a link to our bug reporting page: http://www.nextgen-gallery.com/report-bug/

    It seems we may not need to do any additional troubleshooting on your site at the moment but if you want to share log in details for our developers to review this issue later that would be great!

    – Cais.

    Itsacon

    (@itsacon)

    9 years, 11 months ago

    Hi, I’ve run into this problem as well.

    Looking into the code, I’ve located the problem and applied a temporary fix on my own site.

    The problem is that the NGG hooks are run after the wp-typography hooks. This causes the [nextgen ] shortcodes to be styled with span elements, and quotes to be replaced with fancier quotes.
    After this, NGG can’t decipher its own shortcodes, causing the plugin to fail.

    In wp-typography, the priority of the hooks (add_filter) is set to 99, which used to be enough.

    At some point in the version history howeever, NGG set most of its hooks to priority PHP_INT_MAX or PHP_INT_MAX-1. Obviously, this makes them run last.

    On my own site I’ve changed the values for NGG to slightly lower, and modified wp_typography to use PHP_INT_MAX, but obviously this will break with the next NGG update. (wp-typography is no longer being actively upgraded, I’m afraid).

    Since NGG has set itself at the absolute max, fixing this requires changes to both plugins, so even if wp-typography was being updated, there’s nothing the developer could do. I’d suggest to the developers to either set this to a slightly less absolute value, or add it to the settings, so people can change it if they have other plugins that need that `absolute last’-spot in the queue.

    I’m not familiar with the inner workings of NGG, but why does it need to run that late in the plugin queue?

    Plugin Contributor photocrati

    (@photocrati)

    9 years, 11 months ago

    @itsacon – Thanks for the feedback and work-around for the other plugin.

    The “last” priority is used mostly to ensure compatibility with other plugins, in this case the logic fails … I would guess that wp-typography may have been experiencing similar issues and set their priority to later in the stack, we just chose a much more “absolute” priority as our method.

    I’ll put a note into the developers for them to review these ideas.

    – Cais.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘wp-Typography Plugin causes issue with NextGen Gallery 2.0.14’ is closed to new replies.

Tags