Great, but needs a little update

  • h4ir9

    (@h4ir9)


    11 years, 1 month ago

    Works like a charm.

    However, when using the server-side method, non-image uploads (like PDF documents) are broken.
    I had to edit the regex in the rewrite rule as follows:
    RewriteRule ^files/(.+.(?:jpe?g|gif|png)) wp-content/plugins/wp-retina-2x/wr2x_image.php?ms=true&file=$1 [L]
    Now it only applies to image files.
    Would be great if this was included in a future update!

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Jordy Meow

    (@tigroumeow)

    11 years, 1 month ago

    Hey h4ir9,

    I can’t have ‘files’ in the regexp but I could write the following instead:
    ^(.+.(?:jpe?g|gif|png))

    Would that work for you? But would you mind explaining the difference with the previous one? That is:
    ^.*\.(jpg|jpeg|gif|png|bmp)

    Thanks, for sure I will include it in the next update 🙂

    Thread Starter h4ir9

    (@h4ir9)

    11 years, 1 month ago

    That solution should work as well.
    However, the plugin gives me the message

    You must edit your .htaccess manually and add ‘RewriteRule ^files/(.+) wp-content/plugins/wp-retina-2x/wr2x_image.php?ms=true&file=$1 [L]‘ as the first RewriteRule if you want the server-side to work.

    … and that breaks non-image files. (I have a multisite installation)

    Plugin Author Jordy Meow

    (@tigroumeow)

    11 years, 1 month ago

    Oh, I understand now, you were talking about this message! 🙂 It will be updated in the next release 🙂

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Great, but needs a little update’ is closed to new replies.