Support » Plugin: Facebook Thumb Fixer » 1.7 breaks shortcode processing in page body

  • Resolved stucyber

    (@stucyber)


    Hi Michael,

    first of all thanks for developing and maintaining your useful plugin. After updating to 1.7 I made some Facebook related offline tests and could not find any issues, so i gladly updated on my life site. Now, some days later and with your new updates coming up, I realized that already with 1.7 processing of my shortcodes in the page body stopped. After deactivating Facebook Thumb Fixer everything works fine again. I did some testing and could find the regression dating back to 1.7, 1.6 still works for me.
    Affected shortcodes are: All-in-one-event-calendar and some via functions.php manually registered code block deriving from Jetpack. I’m using the customizr theme.
    You can watch the issue yourself at https://www.s-c-b.org/termine/. I did not revert back to 1.6. online to give you the chance to have a look, so far I’m not losing any vital content here.

    Thanks for paying attention and good luck
    David

    • This topic was modified 4 months ago by  stucyber. Reason: typo
Viewing 15 replies - 1 through 15 (of 25 total)
  • stucyber

    (@stucyber)

    There’s one more thing that maybe points you in the right direction:
    When checking the link above you can see my “Anmelden” button from a mailinglist register form has somehow “slipped” to the right of the address field.

    In comparison to the homepage and the contact page the form uses exactly the same code and css formatting for the form div, but somehow the button shows inline. No idea how this might help you, but reverting back to 1.6 also fixes this.

    Regards
    David

    stucyber

    (@stucyber)

    Last remark so far: Deactivating All-in-one-Event-Calendar plugin restores FBTF functions back to normal after 1.6, so something from 1.7 is obviously interferring with the way ai1ec processes code. Since 1.6 was still working fine, I still assume FBTF to be the “perpetrator”. Anyway, there is a known issue with ai1ec and PHP (no PHP7 support, agressive and therefore broken PHP-error-handling) which might help you to track the problem.

    Regards, David

    Plugin Author Michael Ott

    (@mikeyott)

    Thanks for this detailed feedback. I wish everyone was a meticulous.

    I’ve been thinking about this – and looking at you HTML. Honestly I can’t think of a single thing that I changed that could cause what you described. My plugin only outputs meta data into the head, nowhere else, and the pages you singled out all pass the Facebook Debugger with flying colours (even without an FB app ID). And there’s no malformed markup either (which was my first thought).

    It doesn’t interfere with the output of the page body, and in the case for the contact page you mentioned I’m at a loss to explain. Nothing obvious comes to mind.

    That said, all I can say is that I’ll see if I can find some time to download Ai1EC and see what happens (I assume it’s free). But don’t hold your breathe. I’m sorry to report I’ve got other priorities needing my attention right now (stuff I actually get paid for 🙂 that will keep me busy for a while.

    Does your PHP error log reveal anything obvious? Mine is not showing any errors.

    Thanks in advance.

    stucyber

    (@stucyber)

    Hi Michael,
    thanks for your detailed reply and the digging you’ve done so far. I’ll check PHP errors soon and will give feedback, a first look into your php left me also clueless – maybe a second one reveals a bit. Til then keep on earning, would be a shame if you would have to stop developing on ftf at all 😉

    Thank you
    David

    aoverton

    (@aoverton)

    I’m experiencing this same issue, the problem is being caused by the new feature to use truncated main content when the excerpt does not exist.

    This is causing shortcodes to be prematurely rendered by the plugin and injected into the <meta itemprop=”description”… /> tag.

    Plugin Author Michael Ott

    (@mikeyott)

    @aoverton

    That makes perfect sense. Seeing as I have never (ever) used a shortcode in the content editor, I never considered this possibility.

    I’ll update it over the weekend. I can’t honestly think of a way to get around that aside from simply removing the condition that uses truncated content when an except doesn’t exist, and instead you’ll just need to have an excerpt like it was before.

    Unfortunately there doesn’t appear to be an existing WP function for checking if any shortcode exists, only functions to check for specific shortcodes (which would be ridiculous to consider in this case).

    That said, maybe I’ll add a subtle warning the excerpt field has been left empty.

    Stay tuned.

    PhilHilton

    (@philhilton)

    Plugin Author Michael Ott

    (@mikeyott)

    Awesome 2 the m@x

    If y’all (@stucyber + @aoverton + @philhilton) would like to test it (once I’ve updated it) before I push it to the repo that would be great. Reach me here at the email address noted in the plugin and I’ll send you a copy.

    If not interested, that’s totally cool.

    PhilHilton

    (@philhilton)

    I don’t have a case that breaks it, but if someone wants to supply me post data that does I’ll throw it on a dev box. phil ~aattt~ interfix.net

    stucyber

    (@stucyber)

    @mikeyott

    Of course I’ll test 🙂
    You’ve got mail.

    Plugin Author Michael Ott

    (@mikeyott)

    Awse. Give me a day or two.

    • This reply was modified 4 months ago by  Michael Ott.
    aoverton

    (@aoverton)

    Thanks @mikeyott email sent

    Plugin Author Michael Ott

    (@mikeyott)

    All sorted, update pushed out.

    Now it’s working as expected. Thank you @mikeyott for pushing this through so fast and to @aoverton and @philhilton for providing the essential hints!

    Regards
    David

    P.S. Will add a translation to show some gratitude 😉

    P.S. Will add a translation to show some gratitude

    German translation submitted and awaiting approval.

Viewing 15 replies - 1 through 15 (of 25 total)
  • You must be logged in to reply to this topic.