WordPress.org

1. Konstantin Kovshenin
   Member
   Posted 2 years ago #

   Hey there.. Found a few issues in WP-Syntax so I'd like to point them out here, perhaps the author will eventually see this and solve it.

   The italics in code comments is 1px higher than all the other text, this completely breaks on Firefox 3.5 in Windows when the code is ~ 100 lines or more. I fixed it by restyling code comments in the genshi object.

   Second, who the hell includes CSS like this? echo "\n".'<link rel="stylesheet" href="' . $css_url . '" type="text/css" media="screen" />'."\n"; that's aweful! Please, PLEASE use wp_enqueue_style, you're disallowing parallel downloads by throwing your CSS below all the JS.

   Thanks,
   ~ @kovshenin

2. Konstantin Kovshenin
   Member
   Posted 2 years ago #

   Here's a fix for the second issue:

   Change line 62 (echo "\n...) to: wp_enqueue_style("wp-syntax", $css_url);
   Change line 160 (add_action('wp_head...) to: add_action('wp_print_styles', 'wp_syntax_head');

   That should do it.

Topic Closed

This topic has been closed to new replies.