WordPress.org

Ready to get started?Download WordPress

Forums

WP-Ad-Manager
[resolved] WP-Ad-Manager and Ad-minister databases (14 posts)

  1. genesteinberg
    Member
    Posted 3 years ago #

    A good idea, but I have a long-standing ad setup with Ad-minister. When I replaced that plugin with the modified version — and made a single change in the contents of one ad block, it messed up our entire theme, putting all ads and text in the wrong place. Reverting to Ad-minister didn't work; I had to restore from a previous database backup.

    So I'm hopeful for this new version, but it has a ways to go. You need to be able to read the old data without messing up things once something is changed in an ad.

    Peace,
    Gene

    http://wordpress.org/extend/plugins/wp-ad-manager/

  2. valentinas
    Member
    Plugin Author

    Posted 3 years ago #

    Hi,

    Actually the wp-ad-manager is based on ad-minister code and I haven't changed much in the data reading/writing layer, so i was under impression that it was compatible with ad-minister data. Apparently i was wrong. This shouldn't be a big issue and i think i can fix it in next few days. I'll let you know how it goes (if you still eager to try it).

    Thanks again for reporting, feedback like that is much appreciated!

  3. genesteinberg
    Member
    Posted 3 years ago #

    I'm very eager to try it. Keep me posted.

    Peace,
    Gene

  4. valentinas
    Member
    Plugin Author

    Posted 3 years ago #

    Hi, I've just tested wp-ad-manager with some ad-minister data. Everything seems to work fine for me.

    Probably the easiest way for me to find what's causing the mess would be to test it on your website. I don't want to do that on live site, but if you could share your files/db_backup with me I could test and debug it on my local server. If that sounds like an option for you, then my email is v.bakaitis@gmail.com .

    Also It would be very helpful, if you could provide me some additional information like:

    - ad-minister, wp-ad-manager and wordpress versions you've been using,
    - Actual result (you've mentioned that everything was in wrong places, but could you be more specific and tell me if the ads were in wrong positions, if there was any corrupted formatting, corrupted positions markup or any other things? And what was the change you've made that triggered the bug?)

    Thanks!

  5. genesteinberg
    Member
    Posted 3 years ago #

    I didn't see the problem until I actually opened an ad and made minor edits, none of which related to formatting. On one ad, opening it produced bogus </br> commands.

    Peace,
    Gene

  6. genesteinberg
    Member
    Posted 3 years ago #

    Just to add, I have emailed Valentinas all of the relevant files and I await further information.

    Peace,
    Gene

  7. valentinas
    Member
    Plugin Author

    Posted 3 years ago #

    Gene,
    Thanks again for files!
    I discovered that the issue is related to wordpress WYSIWYG editor. It removes some HTML elements (like <iframe>) when you switching from Visual view to HTML view and back. At the moment I'm trying to find a way how to force editor to leave all tags in place. No luck so far, but I'm on it, and i hope i will find a fix in next few days.

    V.

  8. genesteinberg
    Member
    Posted 3 years ago #

    Glad to hear that you're on the way towards a solution.

    Does it make sense to even have WYSIWYG in that sort of plugin?

    Peace,
    Gene

  9. valentinas
    Member
    Plugin Author

    Posted 3 years ago #

    In your case (when you have bits of code from various sources) probably not, but i had many clients that want to promote themselves or don't have any code, just a picture or the text, so WYSIWYG is for people like them.

    I probably will create an option to turn off WYSIWYG for people who don't want it or don't need it.

    Status update: I've found the way to keep all the tags in editor, there's only one issue left: the editor removes some <p> tags when switching to visual and back. I hope to find a solution in next days.

  10. genesteinberg
    Member
    Posted 3 years ago #

    OK, thanks for the update.

    Peace,
    Gene

  11. valentinas
    Member
    Plugin Author

    Posted 3 years ago #

    Update on this issue:
    after lots of unsuccessful tries to solve this issue in 0.7 i have decided to leave the editor as is for now. It should work ok if you use it in HTML mode (not visual). To turn HTML mode without ruining your content just select and ad to edit, turn to HTML mode and refresh the page (without saving changes). Now you will have your code in HTML and saving it shouldn't ruin anything.

    Also something about what i am planing in the near future: i will make ads as custom post type. that way you will have the whole wordpress ui, properly working editor and so on..

    Though i can't tell exact date when you can expect that. maybe in a month or two. Because so far i am working alone on this.

  12. genesteinberg
    Member
    Posted 3 years ago #

    So will there be a maintenance fix before then for the other issues?

    Peace,
    Gene

  13. valentinas
    Member
    Plugin Author

    Posted 3 years ago #

    I just tagged 0.7.4 version which includes fixes to editor. So far i noticed that it wont work with external script like
    <script src="http://example.com/script.js"></script>
    Everything else should work. More or less :) All issues with editor will be solved in 0.8, since then it will be handled by WordPress.

  14. genesteinberg
    Member
    Posted 3 years ago #

    I will keep testing it on two of our sites.

    I do notice, by the way, that the name is still referred to as Ad-minister in some places.

    Just FYI.

    Peace,
    Gene

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic