WordPress.org

Ready to get started?Download WordPress

Forums

WP Post to PDF Enhanced
Works really well (4 posts)

4 stars
  1. Max Pen
    Member
    Posted 3 months ago #

    Giving this 4 stars because it is not perfect for 5 stars.

    You can add a logo uploader function which is not to hard to do.

  2. Lewis Rosenthal
    Member
    Plugin Author

    Posted 3 months ago #

    Thanks for your review and for your suggestion.

    As you seem to believe that adding such a feature is not hard to do, please submit code, and I shall be sure to include it in an upcoming release. I assume that you are familiar with using the WP API to ensure that malicious code cannot be uploaded to the system during such an operation? Security has been the main reason why I have not looked closely at doing something like this.

    Thanks!

    Lewis

  3. Max Pen
    Member
    Posted 3 months ago #

    Well no but I seen it on a lot of other plugins. And with a lot I mean really a lot. A uploading function seems common practice so they all must have some way of making sure you can't upload malicious code on it.

    Apologies if I gave the impression I had such code.

  4. Lewis Rosenthal
    Member
    Plugin Author

    Posted 3 months ago #

    No worries, and I didn't mean to come off sounding snarky, either. There are indeed a good number of plugins which allow for uploading (sometimes arbitrary) files. I have made a conscious decision to wait to implement such a convenience until I have some other things out of the way, specifically because of security concerns. WP does provide a method for doing this, but I have not tested (or stress tested) it in any way. So, my approach has been to simply provide a pointer to where the file should be placed, and leave it to some other mechanism to get the file there (thus, it's out of my hands as to whether the file is legitimate or not, so my code can't be used for nefarious purposes).

    If you can provide me with a link to a good example of a plugin which allows such file uploading, I am certainly willing to examine the code to see if it can be easily adapted. A quick search comes up with one such example, here, albeit from 2010. I may have another look at this after the next release.

    Cheers, and thanks again for the suggestion.

    Lewis

Reply

You must log in to post.

About this Plugin

About this Topic

Tags

No tags yet.